Node tests fixes #106371

aojea · 2021-11-12T08:20:26Z

/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:

https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable

NONE

aojea · 2021-11-12T08:23:47Z

/sig node
@ehashman does this run on presubmit?
tests were only asserting against one pod
https://play.golang.org/p/Z_BM272C0X2
😅

aojea · 2021-11-12T08:25:14Z

/assign @ehashman @pacoxu

aojea · 2021-11-12T08:31:38Z

/test

k8s-ci-robot · 2021-11-12T08:31:39Z

@aojea: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-kubernetes-conformance-kind-ga-only-parallel
/test pull-kubernetes-dependencies
/test pull-kubernetes-dependencies-go-canary
/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-gce-big-performance
/test pull-kubernetes-e2e-gce-canary
/test pull-kubernetes-e2e-gce-large-performance
/test pull-kubernetes-e2e-gce-large-performance-canary
/test pull-kubernetes-e2e-gce-network-proxy-http-connect
/test pull-kubernetes-e2e-gce-no-stage
/test pull-kubernetes-e2e-gce-ubuntu
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-gce-ubuntu-containerd-canary
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-files-remake
/test pull-kubernetes-integration
/test pull-kubernetes-integration-go-canary
/test pull-kubernetes-kubemark-e2e-gce-scale
/test pull-kubernetes-node-e2e-alpha
/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-typecheck
/test pull-kubernetes-unit
/test pull-kubernetes-unit-go-canary
/test pull-kubernetes-verify
/test pull-kubernetes-verify-go-canary
/test pull-kubernetes-verify-govet-levee

The following commands are available to trigger optional jobs:

/test check-dependency-stats
/test pull-kubernetes-conformance-image-test
/test pull-kubernetes-conformance-kind-ga-only
/test pull-kubernetes-conformance-kind-ipv6-parallel
/test pull-kubernetes-cross
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-containerd
/test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim
/test pull-kubernetes-e2e-aks-engine-azure-file-windows-containerd
/test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim
/test pull-kubernetes-e2e-aks-engine-gpu-windows-dockershim
/test pull-kubernetes-e2e-aks-engine-windows-containerd
/test pull-kubernetes-e2e-aks-engine-windows-dockershim
/test pull-kubernetes-e2e-capz-azure-disk
/test pull-kubernetes-e2e-capz-azure-disk-vmss
/test pull-kubernetes-e2e-capz-azure-file
/test pull-kubernetes-e2e-capz-azure-file-vmss
/test pull-kubernetes-e2e-capz-conformance
/test pull-kubernetes-e2e-capz-ha-control-plane
/test pull-kubernetes-e2e-capz-windows-dockershim
/test pull-kubernetes-e2e-containerd-gce
/test pull-kubernetes-e2e-gce-alpha-features
/test pull-kubernetes-e2e-gce-correctness
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-e2e-gce-iscsi
/test pull-kubernetes-e2e-gce-iscsi-serial
/test pull-kubernetes-e2e-gce-kubetest2
/test pull-kubernetes-e2e-gce-network-proxy-grpc
/test pull-kubernetes-e2e-gce-storage-disruptive
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gci-gce-autoscaling
/test pull-kubernetes-e2e-gci-gce-ingress
/test pull-kubernetes-e2e-gci-gce-ipvs
/test pull-kubernetes-e2e-iptables-azure-dualstack
/test pull-kubernetes-e2e-ipvs-azure-dualstack
/test pull-kubernetes-e2e-kind-canary
/test pull-kubernetes-e2e-kind-dual-canary
/test pull-kubernetes-e2e-kind-ipv6-canary
/test pull-kubernetes-e2e-kind-ipvs-dual-canary
/test pull-kubernetes-e2e-kind-multizone
/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-ubuntu-gce-network-policies
/test pull-kubernetes-e2e-windows-gce
/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-local-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e
/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2
/test pull-kubernetes-node-crio-e2e
/test pull-kubernetes-node-crio-e2e-kubetest2
/test pull-kubernetes-node-e2e
/test pull-kubernetes-node-e2e-alpha-kubetest2
/test pull-kubernetes-node-e2e-containerd-features
/test pull-kubernetes-node-e2e-containerd-features-kubetest2
/test pull-kubernetes-node-e2e-containerd-kubetest2
/test pull-kubernetes-node-e2e-kubetest2
/test pull-kubernetes-node-e2e-podutil
/test pull-kubernetes-node-kubelet-eviction
/test pull-kubernetes-node-kubelet-eviction-kubetest2
/test pull-kubernetes-node-kubelet-serial
/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2
/test pull-kubernetes-node-kubelet-serial-cpu-manager
/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
/test pull-kubernetes-node-kubelet-serial-dockershim
/test pull-kubernetes-node-kubelet-serial-hugepages
/test pull-kubernetes-node-kubelet-serial-kubetest2
/test pull-kubernetes-node-kubelet-serial-memory-manager
/test pull-kubernetes-node-kubelet-serial-topology-manager
/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2
/test pull-kubernetes-node-memoryqos-cgrpv2
/test pull-kubernetes-node-swap-fedora
/test pull-kubernetes-node-swap-ubuntu
/test pull-kubernetes-unit-experimental
/test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-dependencies
pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-integration
pull-kubernetes-node-e2e-containerd
pull-kubernetes-typecheck
pull-kubernetes-unit
pull-kubernetes-verify
pull-kubernetes-verify-govet-levee

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aojea · 2021-11-12T08:32:18Z

/test pull-kubernetes-node-e2e
/test pull-kubernetes-node-kubelet-serial

This reverts commit 990e950.

aojea · 2021-11-12T21:28:54Z

/test pull-kubernetes-node-kubelet-serial

test/e2e_node/restart_test.go

Co-authored-by: Mike Miranda <mikemp96@gmail.com>

aojea · 2021-11-12T22:10:12Z

/test pull-kubernetes-node-kubelet-serial

SergeyKanzhelev · 2021-11-12T22:10:57Z

test/e2e_node/resource_collector.go


 			gomega.Expect(e2epod.WaitForPodToDisappear(f.ClientSet, f.Namespace.Name, pod.ObjectMeta.Name, labels.Everything(),
 				30*time.Second, 10*time.Minute)).NotTo(gomega.HaveOccurred())
-		}(pod)
+		}()


hm, thinking about it, this is not a problem. When pod is passed as argument here, things should be fine

we can keep either new format or revert, shouldn't make a difference

SergeyKanzhelev

/lgtm

k8s-ci-robot · 2021-11-12T22:13:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e_node/OWNERS~~ [SergeyKanzhelev,aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mmiranda96 · 2021-11-12T22:19:59Z

I think the serial test was passing before the last changes, but let's just wait.

/lgtm
Thanks!

pacoxu · 2021-11-15T02:50:35Z

/label tide/merge-method-squash
/hold cancel
since both are /lgtmed.

pull-kubernetes-node-kubelet-serial failure will be fixed by #106408

k8s-ci-robot · 2021-11-15T03:18:57Z

@aojea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-kubelet-serial	`ba19c54`	link	false	`/test pull-kubernetes-node-kubelet-serial`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pacoxu · 2021-11-15T03:26:33Z

/test pull-kubernetes-unit

farhan787 · 2021-11-15T10:22:28Z

test/e2e_node/density_test.go

+	for i := range pods {
+		pod := pods[i]


Why are we using pod := pods[i] now instead of what range function returns us i.e., _, pod := range pods?

see #106371 (comment) pod := pods[i] is same as pod := pod when using _, pod := range pods

@jonyhy96 I know they both are same, now I get it it's because of consistency in code, thanks for mentioning that comment (I missed that).

k8s-ci-robot requested review from pacoxu and resouer November 12, 2021 08:22

aojea changed the title ~~Flake node~~ Node tests fixes Nov 12, 2021

k8s-ci-robot assigned ehashman and pacoxu Nov 12, 2021

aojea mentioned this pull request Nov 12, 2021

dockershim takes 1h30m to successfully kill a pod in node-serial tests #104017

Closed

Antonio Ojea added 4 commits November 12, 2021 10:49

capture loop variable

4503d44

capture the loop variable and don't fail on not found errors

91839a1

capture loop variable

04dfe6c

Revert "Mark restart_test as flaky"

6cb3c4a

This reverts commit 990e950.

aojea force-pushed the flake_node branch from 64dec42 to 6cb3c4a Compare November 12, 2021 09:49

k8s-ci-robot assigned SergeyKanzhelev Nov 12, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021

mmiranda96 reviewed Nov 12, 2021

View reviewed changes

test/e2e_node/restart_test.go Outdated Show resolved Hide resolved

Update test/e2e_node/restart_test.go

6c15b9d

Co-authored-by: Mike Miranda <mikemp96@gmail.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021

capture loop using index

ba19c54

SergeyKanzhelev reviewed Nov 12, 2021

View reviewed changes

SergeyKanzhelev approved these changes Nov 12, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021

k8s-ci-robot assigned mmiranda96 Nov 12, 2021

k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 15, 2021

k8s-ci-robot merged commit 5eb584d into kubernetes:master Nov 15, 2021

SIG Node CI/Test Board automation moved this from Triage to Done Nov 15, 2021

k8s-ci-robot added this to the v1.23 milestone Nov 15, 2021

249043822 mentioned this pull request Nov 15, 2021

[Flaky test] [sig-node] Kubelet should correctly account for terminated pods after restart #105686

Closed

farhan787 reviewed Nov 15, 2021

View reviewed changes

SergeyKanzhelev mentioned this pull request Nov 15, 2021

Linter for incorrect var capture #104835

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node tests fixes #106371

Node tests fixes #106371

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

k8s-ci-robot commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

SergeyKanzhelev Nov 12, 2021

SergeyKanzhelev Nov 12, 2021

SergeyKanzhelev left a comment

k8s-ci-robot commented Nov 12, 2021

mmiranda96 commented Nov 12, 2021

pacoxu commented Nov 15, 2021

k8s-ci-robot commented Nov 15, 2021 •

edited

pacoxu commented Nov 15, 2021

farhan787 Nov 15, 2021

jonyhy96 Nov 15, 2021

farhan787 Nov 16, 2021 •

edited

Node tests fixes #106371

Node tests fixes #106371

Conversation

aojea commented Nov 12, 2021

What this PR does / why we need it:

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

k8s-ci-robot commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

aojea commented Nov 12, 2021

SergeyKanzhelev Nov 12, 2021

Choose a reason for hiding this comment

SergeyKanzhelev Nov 12, 2021

Choose a reason for hiding this comment

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 12, 2021

mmiranda96 commented Nov 12, 2021

pacoxu commented Nov 15, 2021

k8s-ci-robot commented Nov 15, 2021 • edited

pacoxu commented Nov 15, 2021

farhan787 Nov 15, 2021

Choose a reason for hiding this comment

jonyhy96 Nov 15, 2021

Choose a reason for hiding this comment

farhan787 Nov 16, 2021 • edited

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 15, 2021 •

edited

farhan787 Nov 16, 2021 •

edited