Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #100183: Mark volume as uncertain after Unmount* fails #107014

Merged
merged 6 commits into from
Jan 7, 2022
Merged

Automated cherry pick of #100183: Mark volume as uncertain after Unmount* fails #107014

merged 6 commits into from
Jan 7, 2022

Conversation

jsafrane
Copy link
Member

Cherry pick of #100183 on release-1.21.

#100183: Add e2e test for NodeUnstage error cases

For details on the cherry pick process, see the cherry pick requests page.

@jsafrane
Add e2e test for NodeUnstage error cases
fa1cef4
@jsafrane
Fix UnmountDevice error cases
7153720 
When UnmountDevice fails, kubelet treat the volume mount as uncertain,
because it does not know at which stage UnmountDevice failed. It may be
already partially unmonted / destroyed.

As result, MountDevice will be performer when a new Pod is started on the
node after UnmountDevice faiure.
@jsafrane
Add GetPossiblyMountedVolumesForPod to let kubelet know all volumes w…
d592da7 
…ere unmounted

podVolumesExist() should consider also uncertain volumes (where kubelet
does not know if a volume was fully unmounted) when checking for pod's
volumes. Added GetPossiblyMountedVolumesForPod for that.

Adding uncertain mounts to GetMountedVolumesForPod would potentially break
other callers (e.g. `verifyVolumesMountedFunc`).
@jsafrane
Add PodRemovedFromVolume
a1e5e09 
To know when a volume has been fully unmounted (incl. uncertain mounts).
@jsafrane
Refactor dswp unit tests
50da465 
Change existing desiredStateOfWorldPopulator.findAndAddNewPods tests to use
a common initialization function.
@jsafrane
Add unit test for DSWP with uncertain volume
0182c08 
desiredStateOfWorldPopulator.findAndRemoveDeletedPods() should remove
volumes from DSW when a pod is deleted on the API server and the volume is
uncertain in ASW.
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 14, 2021
@k8s-ci-robot
Copy link
Contributor

@jsafrane: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2021
@jsafrane
Copy link
Member Author

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 14, 2021
@jsafrane
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 14, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 14, 2021
@jsafrane
Copy link
Member Author

Note: This is already fixed in 1.22 and newer. I tried to backport it all the way to 1.20, but it's too different and it goes EOL soon.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Dec 15, 2021
@jsafrane jsafrane changed the title Automated cherry pick of #100183: Add e2e test for NodeUnstage error cases Automated cherry pick of #100183: Fixed starting new pods after previous pod timed out unmounting its volumes Dec 16, 2021
@jsafrane jsafrane changed the title Automated cherry pick of #100183: Fixed starting new pods after previous pod timed out unmounting its volumes Automated cherry pick of #100183: Mark volume as uncertain after Unmount* fails Dec 16, 2021
@jsafrane jsafrane mentioned this pull request Dec 16, 2021
Closed
@gnufied
Copy link
Member

gnufied commented Dec 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2021
@jingxu97
Copy link
Contributor

/approve

@jingxu97
Copy link
Contributor

@Random-Liu could you help approve?

@sjenning
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@jsafrane
Copy link
Member Author

Ping @kubernetes/release-managers for approval.

@ehashman ehashman moved this from Triage to Done in SIG Node PR Triage Jan 5, 2022
cpanato
cpanato approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

SIG Node CI/Test Board automation moved this from Archive-it to PRs - Needs Approver Jan 7, 2022
@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jingxu97, jsafrane, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 90fdd27 into kubernetes:release-1.21 Jan 7, 2022
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Jan 7, 2022
@jsafrane jsafrane mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@gnufied gnufied

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @k8s-ci-robot @gnufied @jingxu97 @sjenning @cpanato