Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve reliability of storage List tests. #107330

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Slightly improve reliability of storage List tests. #107330

merged 1 commit into from
Jan 7, 2022

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jan 5, 2022

It's a preparation for unifying List and GetToList further (take the next step from #106542)

NONE

/sig api-machinery
/priority important-longterm
/kind cleanup

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/apiserver labels Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 5, 2022

/retest

@wojtek-t wojtek-t force-pushed the simplify_storage_interface_tests_readability branch from ab58683 to 8ca6c59 Compare January 5, 2022 15:27
@wojtek-t wojtek-t changed the title Change storage.List interface to utilize recursive paramater Slightly improve reliability of storage List tests. Jan 5, 2022
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 5, 2022

@jpbetz - would you mind reviewing this simple PR?

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 6, 2022
@MadhavJivrajani
Copy link
Contributor

/test pull-kubernetes-integration
(flake fixed: #107200)

@jpbetz
Copy link
Contributor

jpbetz commented Jan 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8691d6e into kubernetes:master Jan 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wojtek-t @k8s-ci-robot @fedebongio @MadhavJivrajani @jpbetz