Fix kubetest errors when executing local provider

[ZeusPerez]

What type of PR is this?

/kind bug

What this PR does / why we need it:

I'm trying to run the end-2-end tests locally using kind for running the Kubernetes cluster, and when I execute kubetest --provider local --deployment local --test --check-version-skew false I get 2 errors:

The first one:

2022/01/06 13:30:10 main.go:284: Running kubetest version: 
2022/01/06 13:30:10 process.go:153: Running: $HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson
$HOME/kubernetes/kubernetes/cluster/../cluster/../hack/lib/util.sh: line 226: kube::log::error: command not found
2022/01/06 13:30:11 process.go:155: Step '$HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson' finished in 1.136083829s
2022/01/06 13:30:11 kubernetes.go:35: kubectl get nodes failed: error during $HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson: exit status 1
2022/01/06 13:30:11 main.go:331: Something went wrong: encountered 1 errors: [error during $HOMEts/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson: exit status 1]

This is because it doesn't find the kube::log::error. I've solved it adding source "${KUBE_ROOT}/hack/lib/logging.sh" to cluster/kubectl.sh

The second one is:

2022/01/06 13:33:59 main.go:284: Running kubetest version: 
2022/01/06 13:33:59 process.go:153: Running: $HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson
!!! [0106 13:33:59] Failed to find binary kubectl for platform darwin/amd64
2022/01/06 13:33:59 process.go:155: Step '$HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson' finished in 666.903805ms
2022/01/06 13:33:59 kubernetes.go:35: kubectl get nodes failed: error during $HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson: exit status 1
2022/01/06 13:33:59 main.go:331: Something went wrong: encountered 1 errors: [error during $HOME/kubernetes/kubernetes/cluster/kubectl.sh get nodes -ojson: exit status 1]

In this case, the script is looking for the kubectl binary in:

      "${KUBE_ROOT}/_output/local/go/bin/${lookfor}"
      "${KUBE_ROOT}/_output/dockerized/go/bin/${lookfor}"

Not sure if I miss any setup step for the test, but I have that binary in my $PATH and I would expect that it would be a valid location too.

To solve this, I added this for finding the executable in the $PATH too:

  if which ${lookfor} >/dev/null; then
    local -r local_bin="$(which ${lookfor})"
    locations+=( "${local_bin}"  );
  fi

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

This is my first time contributing to Kubernetes and I'm not completely sure that my premises are correct.

Does this PR introduce a user-facing change?

NONE

[linux-foundation-easycla]

• ❌ The commit (756ac7514d82614d0a75921c7abd7dc7f056d0fd ,126c97c30d23cf4f04f7b2f5fe4be049f2ca923c) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @ZeusPerez!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

@ZeusPerez: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @ZeusPerez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

• ❌ The commit (756ac7514d82614d0a75921c7abd7dc7f056d0fd ,cf72d13b5a29959e670d093989a8e57c37db5385) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ❌ The commit (63218137c9457d91fa4b5d29c5aec18b17530c22 ,ae7a59e316f29d4d5d8620e5ea1447a8648b252b) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ❌ The commit (63218137c9457d91fa4b5d29c5aec18b17530c22 ,ee29d9bb14be4aeb894eb3e2fa29e66e57abb4c2) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ❌ The commit (63218137c9457d91fa4b5d29c5aec18b17530c22 ,4d7c27068000c116305ed3282dcd618e196456d4) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla]

• ✅ ZeusPerez (1f9476a826947dc27367d516d4dc7a62b3062cce)

• ❌ The commit (63218137c9457d91fa4b5d29c5aec18b17530c22) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[dims]

/ok-to-test
/sig testing
/assign

[ZeusPerez]

/test pull-kubernetes-verify

[ZeusPerez]

/test pull-kubernetes-e2e-kind

[ZeusPerez]

/test pull-kubernetes-integration

[ZeusPerez]

/test pull-kubernetes-conformance-kind-ga-only-parallel

[dims]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ZeusPerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster/OWNERS [dims]
• hack/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest