Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 in echoserver #107392

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

johngmyers
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This extends the echoserver so that it also listens on IPv6.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

@johngmyers: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2022
@dims
Copy link
Member

dims commented Jan 6, 2022

@johngmyers tested this locally already?

@johngmyers
Copy link
Member Author

Yes, tested a private amd64-only image build in an IPv6-only cluster.

@johngmyers
Copy link
Member Author

curl http://'[fd00:5e4f:ce::e2b3]':80  


Hostname: echoserver-557bb6dc7c-tzhd4

Pod Information:
	-no pod information available-

Server values:
	server_version=nginx: 1.14.2 - lua: 10015

Request Information:
	client_address=2600:1f18:1e5f:8501:570d::6a35
	method=GET
	real path=/
	query=
	request_version=1.1
	request_scheme=http
	request_uri=http://[fd00:5e4f:ce::e2b3]:8080/

Request Headers:
	accept=*/*
	host=[fd00:5e4f:ce::e2b3]
	user-agent=curl/7.68.0

Request Body:
	-no body in request

@dims
Copy link
Member

dims commented Jan 6, 2022

/approve

leaving lgtm for @mkumatag or other reviewers.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@oomichi
Copy link
Member

oomichi commented Jan 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 595bc88 into kubernetes:master Jan 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 7, 2022
@johngmyers johngmyers deleted the ipv6-echoserver branch January 7, 2022 04:06
@aojea
Copy link
Member

aojea commented Jan 7, 2022

I think that this functionality is already in the agnhost image 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants