Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #102122: Don't set sysctl net.ipv4.vs.conn_reuse_mode for kernels #107438

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Automated cherry pick of #102122: Don't set sysctl net.ipv4.vs.conn_reuse_mode for kernels #107438

merged 1 commit into from
Jan 11, 2022

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Jan 10, 2022

Cherry pick of #102122 on release-1.21.

#102122: Don't set sysctl net.ipv4.vs.conn_reuse_mode for kernels

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 10, 2022
@gjkim42
Copy link
Member Author

gjkim42 commented Jan 10, 2022 •
edited

/cc @uablrek @aojea @pacoxu

I think we need to cherry-pick this as this affects a lot of use cases.
#81775 (comment)

@gjkim42
Copy link
Member Author

gjkim42 commented Jan 10, 2022

/retest

@pacoxu
Copy link
Member

pacoxu commented Jan 10, 2022

/kind bug
/release-note-none
/lgtm
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2022
@aojea
Copy link
Member

aojea commented Jan 10, 2022

/approve
ping @kubernetes/release-managers

@aojea
Copy link
Member

aojea commented Jan 10, 2022

/assign @thockin
I don't have approval powers here 😄

thockin
thockin reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
saschagrunert
saschagrunert approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 11, 2022
@saschagrunert saschagrunert added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, gjkim42, saschagrunert, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Jan 11, 2022

/skip
/retest

@k8s-ci-robot k8s-ci-robot merged commit 61b6b6f into kubernetes:release-1.21 Jan 11, 2022
@gjkim42 gjkim42 deleted the automated-cherry-pick-of-#102122-upstream-release-1.21 branch January 11, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@aojea aojea Awaiting requested review from aojea

@pacoxu pacoxu Awaiting requested review from pacoxu

@uablrek uablrek Awaiting requested review from uablrek

Assignees

@saschagrunert saschagrunert

@pacoxu pacoxu

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gjkim42 @pacoxu @aojea @k8s-ci-robot @saschagrunert @thockin