Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off informer for statefulset unit tests #107443

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Turn off informer for statefulset unit tests #107443

merged 1 commit into from
Jan 19, 2022

Conversation

mattcary
Copy link
Contributor

/kind failing-test

Fixes #106615

The situation is explained in the new comment in stateful_set_control_test.go.

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

@mattcary: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 10, 2022
@mattcary mattcary mentioned this pull request Jan 10, 2022
Closed
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 10, 2022
@mattcary
Copy link
Contributor Author

/retest

@mattcary
Copy link
Contributor Author

ping?

@liggitt
Copy link
Member

liggitt commented Jan 12, 2022

would like an apps reviewer to ack

@mattcary
Copy link
Contributor Author

would like an apps reviewer to ack

I've pinged the sig-apps slack 🤞🏾🤞🏾🤞🏾

janetkuo
janetkuo approved these changes Jan 15, 2022
View reviewed changes
pkg/controller/statefulset/stateful_set_control_test.go Outdated
// for client state to sync. In fact, because the client is not updated during tests, informer updates will break tests
// by unexpectedly deleting objects.
//
// It would probably be better to rewrite all these tests manipulate the client an explicitly sync to ensure consistent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it a TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2022
@mattcary
Turn off informer for statefulset unit tests
f2861d7 
Change-Id: I353a2d5bd59963d5d2308eaf7d0e6f77d969fc25
@ash2k
Copy link
Member

ash2k commented Jan 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9d41c13 into kubernetes:master Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 19, 2022
@bobbypage bobbypage mentioned this pull request Jun 9, 2022
Merged
@pacoxu pacoxu mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@janetkuo janetkuo janetkuo approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ash2k ash2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

StatefulSet PVC tests failing
5 participants
@mattcary @k8s-ci-robot @liggitt @ash2k @janetkuo