Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goroutine leaks in package selectorspread #107445

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix goroutine leaks in package selectorspread #107445

merged 1 commit into from
Jan 21, 2022

Conversation

mengjiao-liu
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix goroutine leaks in TestSelectorSpreadScore.

In the for loop, after a test case has ended, the child goroutine should be terminated in time to release resources to avoid the problem of goroutine leakage.

Which issue(s) this PR fixes:

Fixes #107360

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 10, 2022
@mengjiao-liu mengjiao-liu force-pushed the goroutine_leak_TestSelectorSpreadScore branch from 852aa47 to 6a3483d Compare January 11, 2022 07:59
@mengjiao-liu mengjiao-liu changed the title Fix goroutine leaks in TestSelectorSpreadScore Fix goroutine leaks in selector_spread_test.go Jan 11, 2022
@mengjiao-liu
Copy link
Member Author

/retest

@mengjiao-liu mengjiao-liu force-pushed the goroutine_leak_TestSelectorSpreadScore branch from 6a3483d to d0ec334 Compare January 12, 2022 02:20
@mengjiao-liu mengjiao-liu changed the title Fix goroutine leaks in selector_spread_test.go Fix goroutine leaks in package selectorspread Jan 12, 2022
@denkensk
Copy link
Member

/lgtm

Thanks @mengjiao-liu
ping @Huang-Wei for approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@denkensk
Copy link
Member

@alculquicondor
Could you give approve for this?
Thanks

alculquicondor
alculquicondor reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@alculquicondor
Copy link
Member

/retest

1 similar comment
@alculquicondor
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0c8074e into kubernetes:master Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 21, 2022
@Huang-Wei
Copy link
Member

ping @Huang-Wei for approve

Apologize that it totally slipped in my radar. (ping me on slack next time if I don't respond)

It's a neat PR and thank @songlh for spotting it and @mengjiao-liu for fixing it!

I'm drafting a PR to fix all (hopefully) potential goroutine leaks (mostly in UT) in scheduler codebase.

@Huang-Wei Huang-Wei mentioned this pull request Jan 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk denkensk left review comments

@kerthcet kerthcet kerthcet left review comments

@chendave chendave Awaiting requested review from chendave

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@denkensk denkensk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

goroutine leaks in TestSelectorSpreadScore
6 participants
@mengjiao-liu @k8s-ci-robot @denkensk @alculquicondor @Huang-Wei @kerthcet