Fix AppArmor unloaded profile e2e test #107448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
saschagrunert
added
sig/node
This was referenced Jan 10, 2022
k8s-ci-robot
added
area/test
sig/testing
|
/test pull-kubernetes-node-e2e-containerd-features |
saschagrunert
force-pushed
the
apparmor-e2e
branch
from
30a1cc7
to
5ef0229
Compare
With the removal of the kubelet AppArmor profile validation in kubernetes#97966 we passed the responsibility of the desired behavior to the container runtime. Therefore we have to change the e2e test which silently broke after the PR merge. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
apparmor-e2e
branch
from
5ef0229
to
fcca81a
Compare
|
/test pull-kubernetes-node-e2e-containerd-features |
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Ready for review, PTAL |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
lgtm
|
/test |
|
@SergeyKanzhelev: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-swap-ubuntu |
|
this job ^^^ should run the affected test |
SergeyKanzhelev
approved these changes
Jan 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
/test pull-kubernetes-unit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
With the removal of the kubelet AppArmor profile validation in #97966 we passed the responsibility of the desired behavior to the container runtime. Therefore we have to change the e2e test which silently broke after the PR merge.
Which issue(s) this PR fixes:
Fixes #107342
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: