Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluent bit version to 1.8.10 for GKE windows container #107478

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Update fluent bit version to 1.8.10 for GKE windows container #107478

merged 1 commit into from
Jan 21, 2022

Conversation

liurupeng
Copy link
Contributor

What type of PR is this?

/kind maintenance

What this PR does / why we need it:

Update component (fluent bit) version on GKE windows container

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

@liurupeng: The label(s) kind/maintenance cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind maintenance

What this PR does / why we need it:

Update component (fluent bit) version on GKE windows container

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 11, 2022 •
edited

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ RupengLiu (a364cc0c36bf63a044271f69d57bc4f73c813895)

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @liurupeng!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @liurupeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2022
@dims
Copy link
Member

dims commented Jan 14, 2022

There is a cncf-cla:no label on this PR. Can you please see the bot comments above to fix the CLA? This PR cannot progress unless the bot is happy with the CLA situation

@liurupeng
Copy link
Contributor Author

Hi, I have signed the CLA, can you take a look? thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 20, 2022
ibabou
ibabou suggested changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ibabou ibabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash both commits together? Just to keep the git history cleaner.

@ibabou
Copy link
Contributor

ibabou commented Jan 20, 2022

/sig windows
/triage accepted
/priority important-soon
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2022
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2022
@ibabou
Copy link
Contributor

ibabou commented Jan 20, 2022

/retest

@ibabou
Copy link
Contributor

ibabou commented Jan 20, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibabou, liurupeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@pacoxu
Copy link
Member

pacoxu commented Jan 21, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 21, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 45b6af6 into kubernetes:master Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 21, 2022
@mauriciopoppe
Copy link
Member

I'm investigating why Windows CI builds of PD CSI aren't running in kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#892, the error that I see in the bootstrap is

2022/01/25 20:03:33 GCEMetadataScripts: windows-startup-script-ps1: C:\flb-exporter\flb-exporter.exe corrupted, SHA256 @{Algorithm=SHA256; Hash=C808C9645D84B06B89932BD707D51A9D1D0B451B5A702A5F9B2B4462C8BE6502; Path=C:\flb-exporter\flb-exporter.exe} doesn't match expected f84bc732c9078421930cf9791c52066a56e692836e13857133d9927a35663a6b
2022/01/25 20:03:33 GCEMetadataScripts: windows-startup-script-ps1: Hash validation of https://storage.googleapis.com/gke-release/winnode/fluentbit-exporter/v0.17.0/flb-exporter-v0.17.0.exe failed. Will retry. Error: System.Management.Automation.RuntimeException: C:\flb-exporter\flb-exporter.exe corrupted, SHA256 @{Algorithm=SHA256; Hash=C808C9645D84B06B89932BD707D51A9D1D0B451B5A702A5F9B2B4462C8BE6502; Path=C:\flb-exporter\flb-exporter.exe} doesn't match expected f84bc732c9078421930cf9791c52066a56e692836e13857133d9927a35663a6b

I think that this hash belongs to loging exporter and not logging agent, probably we should revert this line

$LOGGINGEXPORTER_HASH = 'f84bc732c9078421930cf9791c52066a56e692836e13857133d9927a35663a6b'

@marosset marosset added this to Done (v1.24) in SIG-Windows Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibabou ibabou ibabou approved these changes

@yliaog yliaog Awaiting requested review from yliaog

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@ibabou ibabou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.24)
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liurupeng @k8s-ci-robot @dims @ibabou @pacoxu @k8s-triage-robot @mauriciopoppe