Remove dashboard cluster addon

[shu-mutou]

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Remove dashboard cluster addon.
Due to dashboard addon is no longer maintained.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Cluster addon for dashboard was removed. To install dashboard, see [here](https://github.com/kubernetes/dashboard/blob/master/docs/user/README.md).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@shu-mutou: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@shu-mutou: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shu-mutou]

/remove-label kind/deprecation

[k8s-ci-robot]

@shu-mutou: The label(s) /remove-label kind/deprecation cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, official-cve-feed

In response to this:

/remove-label kind/deprecation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

/assign floreks

[liggitt]

The entire cluster folder is deprecated. If the dashboard add on isn't used by CI, which I don't think it is, we should simply drop it

[shu-mutou]

Because some other addons are maintaining and I didn't find deprecation policy for addons, I thought this addon should be set as deprecated once.
I agree with removing. I will change this PR to remove entirely this addon.

[floreks]

/lgtm

[maciaszczykm]

/retest

[liggitt]

drop related stuff in the cluster scripts:

CUSTOM_KUBE_DASHBOARD_BANNER and ENABLE_CLUSTER_UI

function update-dashboard-deployment

  if [[ "${ENABLE_CLUSTER_UI:-}" == "true" ]]; then
    setup-addon-manifests "addons" "dashboard"
    local -r dashboard_deployment_yaml="${dst_dir}/dashboard/dashboard-deployment.yaml"
    update-dashboard-deployment ${dashboard_deployment_yaml}
  fi

[oomichi]

kubernetes/hack/local-up-cluster.sh

Line 928 in cf18d80

${KUBECTL} --kubeconfig="${CERT_DIR}/admin.kubeconfig" apply -f "${KUBE_ROOT}/cluster/addons/dashboard/dashboard.yaml"

also still uses the yaml which is deleted with this pull request.

[shu-mutou]

/retest

[atoato88]

k/k/test/e2e/ui/dashboard.go has some tests for dashboard UI.
Should we delete this test?

[liggitt]

k/k/test/e2e/ui/dashboard.go has some tests for dashboard UI.
Should we delete this test?

yes

[oomichi]

/test pull-kubernetes-local-e2e

[oomichi]

pull-kubernetes-local-e2e seems failed due to unrelated reason according to #107626 (comment)

[shu-mutou]

/test pull-kubernetes-local-e2e

[k8s-ci-robot]

@shu-mutou: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-local-e2e	f9954d0	link	false	/test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[shu-mutou]

@dims @liggitt @oomichi @atoato88 @floreks @maciaszczykm Passed required tests. Pleas take a look again. Thanks!

[dims]

/skip
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster/OWNERS [dims]
• hack/OWNERS [dims]
• test/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment