Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KUBE_TEST_ARGS come last, so that -args can be used #107516

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Make KUBE_TEST_ARGS come last, so that -args can be used #107516

merged 1 commit into from
Jan 18, 2022

Conversation

MikeSpreitzer
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR re-arranges the order in which arguments are presented to go test by make test-integration, so that KUBE_TEST_ARGS can usefully include -args.

Which issue(s) this PR fixes:

Fixes #100611

Special notes for your reviewer:

This is a rebased version of #100657 by @gavinfish

Does this PR introduce a user-facing change?

When doing `make test-integration`, you can now usefully include `-args $prog_args` in KUBE_TEST_ARGS.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2022
@k8s-ci-robot
Copy link
Contributor

@MikeSpreitzer: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

/cc @gavinfish
/cc @SataQiu

@MikeSpreitzer
Copy link
Member Author

@kubernetes/sig-testing
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

/cc @spiffxp

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

Undoing bot response to fat finger:
/remove-area apiserver
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 13, 2022
@MikeSpreitzer
Copy link
Member Author

/retest

SataQiu
SataQiu reviewed Jan 16, 2022
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2022
gavinfish
gavinfish reviewed Jan 16, 2022
View reviewed changes
Copy link
Contributor

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MikeSpreitzer
Copy link
Member Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jan 18, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 824145d into kubernetes:master Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 18, 2022
@BenTheElder
Copy link
Member

Just a small note: this technically means those other env are no longer authoritative versus KUBE_TEST_ARGS (they would have been before since they came last), which IMHO makes more sense, but is technically a sort of breaking change.

If anyone's setup is actually broken by this should probably rethink how they set these env though ...

@MikeSpreitzer
Copy link
Member Author

@BenTheElder : what you are saying is that the hack of putting -args $prog_args in KUBE_TEST_VMODULE no longer works (um, did it ever?), right? If so then I am also OK with this change.

@MikeSpreitzer MikeSpreitzer deleted the fix-test-integration branch January 18, 2022 18:19
@BenTheElder
Copy link
Member

I mean the short and vmodule env / args. before this PR they always came last and would overrode any previous args. Folks should not set these except through those env hopefully

@pohly pohly mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinfish gavinfish gavinfish left review comments

@SataQiu SataQiu SataQiu left review comments

@sttts sttts Awaiting requested review from sttts

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@liggitt liggitt

@gavinfish gavinfish

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

There is no way to pass arguments to the test subject in integration testing
6 participants
@MikeSpreitzer @k8s-ci-robot @liggitt @BenTheElder @gavinfish @SataQiu