Test isolation among FlowSchemaStatus Conditions #107572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
wojtek-t
reviewed
Jan 17, 2022
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| if false /* disabled until patch annotations go into the API */ { |
There was a problem hiding this comment.
Please link the issue here (otherwise it will not be clear for many people what patch annotations): #107574
MikeSpreitzer
force-pushed
the
add-flowschema-condition-test
branch
from
8d141b7
to
23af473
Compare
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
wojtek-t
reviewed
Jan 19, 2022
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| if false /* disabled until patch annotations go into the API (see https://github.com/kubernetes/kubernetes/issues/107574) */ { |
There was a problem hiding this comment.
nit: I would personally do:
TODO(#107574): Enable this part of the test once patch annotations go into the API.
But I'm not going to block this PR on it...
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a test that the members of the Condition slice in FlowSchemaStatus can be updated independently.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I tried to continue #107547 but somehow it got wedged.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
@kubernetes/sig-api-machinery-misc
/cc @tkashem
/cc @wojtek-t
@deads2k
@lavalamp