-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include applying subresource in Running section #107588
Conversation
Hi @discordianfish. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
72665e1
to
19bfbfd
Compare
/assign @yliaog |
This looks good to me - should we go ahead and delete the non-status subresource version of this? (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-controller/artifacts/examples/crd.yaml) as I don't think there's ever a case where it's useful anymore? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: discordianfish, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Following the readme before lead to the following error due to the missing subresource:
Since CRD subresources are GA since 1.16, the readme should including applying them.
Does this PR introduce a user-facing change?
NONE