Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] update to Go 1.17.6 #107612

Merged
merged 1 commit into from
Jan 18, 2022
Merged

[go] update to Go 1.17.6 #107612

merged 1 commit into from
Jan 18, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 18, 2022 •
edited

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update to Go 1.17.6

Part of kubernetes/release#2379

Next in line: Similar update PRs for release-1.21, release-1.23 and release-1.23

Which issue(s) this PR fixes:

Part of kubernetes/release#2379

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.6

/assign @dims @liggitt @justaugustus @cpanato
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2022
@palnabarun palnabarun mentioned this pull request Jan 18, 2022
Closed
27 tasks
@palnabarun
Copy link
Member Author

/test pull-kubernetes-e2e-kind

1 similar comment
@palnabarun
Copy link
Member Author

/test pull-kubernetes-e2e-kind

@palnabarun
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

This was referenced Jan 18, 2022
Merged
Merged
cpanato
cpanato reviewed Jan 18, 2022
View reviewed changes
staging/publishing/rules.yaml Outdated
@@ -24,17 +24,17 @@ rules:
branch: release-1.21
dir: staging/src/k8s.io/code-generator
name: release-1.21
go: 1.16.12
go: 1.16.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually, we bump the go for the release branches after all PRs from k/k for the go updates are merged
in this PR we just update the default-go-version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! Will remove the branch rule updates.

Is it to maintain some kind of chronology of changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: Removed the branch rule updates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid to publish bot runs without having the correct versions I guess

@palnabarun
[go] update to Go 1.17.6
77816bd 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2022
@palnabarun palnabarun changed the title [go] update to Go 1.17.6 and Go 1.16.13 [go] update to Go 1.17.6 Jan 18, 2022
@cpanato
Copy link
Member

cpanato commented Jan 18, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2022
cpanato
cpanato reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2022
justaugustus
justaugustus approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/assign @dims @liggitt

@dims
Copy link
Member

dims commented Jan 18, 2022

/approve

1 similar comment
@dims
Copy link
Member

dims commented Jan 18, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
cpanato
cpanato approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@palnabarun
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit ba1fc6f into kubernetes:master Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 18, 2022
@palnabarun palnabarun deleted the releng/go-update branch September 3, 2023 15:46
@palnabarun palnabarun restored the releng/go-update branch September 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@cpanato cpanato cpanato approved these changes

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@palnabarun @cpanato @dims @k8s-ci-robot @justaugustus @liggitt