legacy-script.sh fixes - junit output and add missing record_command #107740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/assign soltysh |
brianpursley
force-pushed
the
legacy-script-fixes
branch
from
2ec3a07
to
5a9189b
Compare
ARTIFACTS environment variables if KUBE_JUNIT_REPORT_DIR is not set. Add missing record_command to a couple of tests in legacy-script.sh. Fix some typos in /test/cmd/README.md
brianpursley
force-pushed
the
legacy-script-fixes
branch
from
5a9189b
to
e120f11
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I was recently reviewing a PR related to the tests in legacy-script.sh and noticed a few problems in the existing code. This PR fixes those problems.
Added
record_commandto the following tests in legacy-script.sh:Added code to set
KUBE_JUNIT_REPORT_DIR(copied fromhack/make-rules/test.sh) to produce junit output in the artifacts directory, so that the individual test results will show up in the build pipeline output's junit section.Fixed some typos in README.md pertaining to how to run individual integration tests.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: