Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data race when hijack klog #107774

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix: data race when hijack klog #107774

merged 1 commit into from
Feb 11, 2022

Conversation

calvin0327
Copy link
Contributor

Signed-off-by: calvin wen.chen@daocloud.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes data race when hijack klog output #106796 (review)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@calvin0327
fix: data race when hijack klog
d9ab5e1 
Signed-off-by: calvin <wen.chen@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2022
@matthyx
Copy link
Contributor

matthyx commented Jan 26, 2022

/kind failing-test
/remove-kind bug
/release-note-none
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@matthyx matthyx added this to Triage in SIG Node CI/Test Board Jan 26, 2022
@jonyhy96
Copy link
Contributor

/retest

endocrimes
endocrimes approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@endocrimes
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2022
@endocrimes endocrimes moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Jan 26, 2022
@jonyhy96
Copy link
Contributor

ping @sjenning for approve

@sjenning
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calvin0327, endocrimes, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7cfe0ca into kubernetes:master Feb 11, 2022
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 11, 2022
@kerthcet kerthcet mentioned this pull request Feb 14, 2022
Closed
@utkarsh348
Copy link
Contributor

utkarsh348 commented Feb 14, 2022 •
edited

This particular change has not resolved the underlying issue of the race condition in the nodeshutdown unit test(I've been able to reproduce the issue).
It has been formally raised 108040

@jonyhy96 jonyhy96 deleted the fix-data-race branch March 3, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@matthyx matthyx Awaiting requested review from matthyx

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@endocrimes endocrimes

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@calvin0327 @matthyx @jonyhy96 @endocrimes @sjenning @k8s-ci-robot @utkarsh348