kubeadm: warn only when config value is different with default value #107785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig cluster-lifecycle |
|
e.g for what I have seen, |
SataQiu
reviewed
Jan 26, 2022
| @@ -223,7 +223,7 @@ func (kc *kubeletConfig) Default(cfg *kubeadmapi.ClusterConfiguration, _ *kubead | |||
| if kc.config.ResolverConfig == nil { | |||
| kc.config.ResolverConfig = utilpointer.String(kubeletSystemdResolverConfig) | |||
| } else { | |||
| if kc.config.ResolverConfig != utilpointer.String(kubeletSystemdResolverConfig) { | |||
| if *kc.config.ResolverConfig != *utilpointer.String(kubeletSystemdResolverConfig) { | |||
There was a problem hiding this comment.
Suggested change
| if *kc.config.ResolverConfig != *utilpointer.String(kubeletSystemdResolverConfig) { | |
| if *kc.config.ResolverConfig != kubeletSystemdResolverConfig { |
There was a problem hiding this comment.
true, this should be better!
Compare with two pointers will always show that they are different value, so it will always print the warning message. Signed-off-by: Dave Chen <dave.chen@arm.com>
|
/test pull-kubernetes-unit |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
lgtm
|
/approve |
|
thanks for the PR @chendave |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/release-note-edit |
k8s-ci-robot
added
the
release-note
k8s-ci-robot
removed
the
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare with two pointers will always show that they are different value,
so it will always print the warning message.
Signed-off-by: Dave Chen dave.chen@arm.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: