-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1.Secret to go-flow-levee analysis targets #107810
Conversation
@tksm: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @tksm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign PurelyApplied |
/lgtm |
/retest |
@tksm: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @IanColdwater |
/assign @tabbysable |
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tabbysable, tksm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds v1.Secret to the list of go-flow-levee analysis targets.
The internal version of Secret (
k8s.io/kubernetes/pkg/apis/core
) was addeddatapolicy
tag in #95992 , but v1.Secret (k8s.io/api/core/v1
) is not tagged. v1.Secret is more widely used than the internal one, so it should be checked.Which issue(s) this PR fixes:
Special notes for your reviewer:
I know KEP-1753 deprecation does not deprecate
datapolicy
tag, but the related PRs such as #95998, #95994, and #96008 were not merged, so I only added it to levee-config.yaml for now.I confirmed that a log line intentionally added a v1.Secret object was detected with this config.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: