Fix panic in Kubelet #107887
Fix panic in Kubelet #107887
Conversation
Currently, the Kubelet panics when it's started with the `enable-controller-attach-detach=false` option set and a volume is attached to a node. This patch adds a check that prevents the Kubelet from trying to attach or detach CSI volumes and report a proper error warning the user that this use case is not supported.
k8s-ci-robot
added
release-note-none
|
@bertinatto: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
k8s-ci-robot
added
sig/storage
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-kubernetes-e2e-gce-storage-slow |
1 similar comment
|
/test pull-kubernetes-e2e-gce-storage-slow |
| @@ -66,6 +66,11 @@ var _ volume.Detacher = &csiAttacher{} | |||
| var _ volume.DeviceMounter = &csiAttacher{} | |||
|
|
|||
| func (c *csiAttacher) Attach(spec *volume.Spec, nodeName types.NodeName) (string, error) { | |||
| _, ok := c.plugin.host.(volume.KubeletVolumeHost) | |||
There was a problem hiding this comment.
Do you know which line was segfaulting? The line number in the stack trace doesn't appear to match this file.
There was a problem hiding this comment.
Line 82 (or 87 after my patch is applied). I think I captured that stack with v1.23.1, but I'm positive the panic happens with the code in the tip was well.
|
/milestone v1.24 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
This patch adds a check that prevents the Kubelet from trying to attach or detach CSI volumes and report a proper error, warning the user that this use case is not supported.
Which issue(s) this PR fixes:
Fixes #107886
Special notes for your reviewer:
Later we'll need a follow-up PR to update the docs.
Does this PR introduce a user-facing change?
-->
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: