E2E: {cpu,topology} manager: improve debuggability #107915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to log out the cpu capacity and allocatable for the node running the tests, to make the troubleshooting of test failures easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
The existing cpu/topology manager tests correctly check for the node resources and skip if the detected resources are not enough to run the tests, to avoid false negatives. Unfortunately they do the check against the node capacity, while the correct approach is to check the allocatable resources. The existing check is correct only on a narrow set of cases; otherwise can still lead to false negatives. This PR fixes that. Signed-off-by: Francesco Romani <fromani@redhat.com>
k8s-ci-robot
added
release-note-none
|
@fromanirh: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
|
/sig node |
k8s-ci-robot
added
sig/node
ffromani
changed the title
k8s-ci-robot
added
area/test
sig/testing
Even though CI machines _usually_ have at least two cpus, let's rather not assume this holds true, and let's actually check the allocatable CPUs, skipping even the simplest tests if the assumption is broken, to avoid false negatives. Signed-off-by: Francesco Romani <fromani@redhat.com>
A cpu/topology manager e2e test wants to require one exclusive CPU and a share of CPU time; let's round up the allocatable CPU requirements (from 1 to 2) to reduce the chances of false negatives. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
e2e-tm-cpum-check-node-allocatable
branch
from
3924d96
to
7004a71
Compare
SergeyKanzhelev
approved these changes
Feb 2, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fromanirh, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/kind failing-test
What this PR does / why we need it:
Improve the debuggability of topology manager e2e tests which were failing lately on the crio lane.
xref: #107805
Which issue(s) this PR fixes:
Fixes N/A
Special notes for your reviewer:
Aiming to make the failures clearer in order to deliver the actual fix
Does this PR introduce a user-facing change?