Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove option 'T' from wget on Windows #107983

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Remove option 'T' from wget on Windows #107983

merged 1 commit into from
Feb 8, 2022

Conversation

hxietkg
Copy link
Contributor

@hxietkg hxietkg commented Feb 7, 2022

Command 'wget' in Windows image agnhost does not support option timeout,
this test fails:

  • should be able to up and down services

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Command wget in Windows image agnhost does not support option 'T', so the test "should be able to up and down services" fails on Windows cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@hxietkg
Remove option 'T' from wget on Windows
83974e4 
Command 'wget' in Windows image agnhost does not support option timeout,
this test fails:
  - should be able to up and down services
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @hxietkg. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2022
neolit123
neolit123 reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kubernetes/sig-windows-bugs

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Feb 7, 2022
@neolit123
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2022
@jayunit100
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@jayunit100
Copy link
Member

(context - hongsheng is getting the ntepol tests vetted fully for windows so , this is one more iterative improvement we found

@marosset
Copy link
Contributor

marosset commented Feb 7, 2022

(context - hongsheng is getting the ntepol tests vetted fully for windows so , this is one more iterative improvement we found

Great. I was just checking and it doesn't look like we run this in https://testgrid.k8s.io/sig-windows-signal#aks-engine-windows-containerd-master.
It looks like we just run the conformance sig-networking tests.

marosset
marosset reviewed Feb 7, 2022
View reviewed changes
test/e2e/network/service.go
@@ -328,7 +328,11 @@ func verifyServeHostnameServiceUp(c clientset.Interface, ns string, expectedPods

// verify service from pod
cmdFunc := func(podName string) string {
wgetCmd := "wget -q -T 1 -O -"
wgetCmd := "wget -q -O -"
// Command 'wget' in Windows image may not support option 'T'
Copy link
Contributor

@marosset marosset Feb 7, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may not?

Is this test using an actual wget binary or relying on the wget powershell alias that is actually just an alias for Invoke-WebRequest?

It looks like this test is using anghost which uses powershell as the default shell so i think this is just using the powershell alias - which also doesn't support -q.

Copy link
Contributor Author

@hxietkg hxietkg Feb 8, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is using wget binary:

STEP: verifying service has 3 reachable backends
Feb  6 23:42:16.428: INFO: Executing cmd "for i in $(seq 1 150); do wget -q -O - http://100.70.143.81:80 2>&1 || true; echo; done" in pod services-2563/verify-service-up-host-exec-pod
Feb  6 23:42:16.428: INFO: Running '/home/kubo/path/kubectl --kubeconfig=/home/kubo/.kube/config --namespace=services-2563 exec verify-service-up-host-exec-pod -- /bin/sh -x -c for i in $(seq 1 150); do wget -q -O - http://100.70.143.81:80 2>&1 || true; echo; done'

here are args of command wget:

/ # wget -h
wget: unknown option -- h                                                       
BusyBox v1.29.0.git (2018-10-29 11:20:48 PDT) multi-call binary                 
                                                                                
Usage: wget [-c|--continue] [--spider] [-q|--quiet] [-O|--output-document FILE] 
        [--header 'header: value'] [-Y|--proxy on/off] [-P DIR]                 
        [-S|--server-response] [-U|--user-agent AGENT] URL...                   
                                                                                
Retrieve files via HTTP or FTP                                                  
                                                                                
        --spider        Only check URL existence: $? is 0 if exists             
        -c              Continue retrieval of aborted transfer                  
        -q              Quiet                                                   
        -P DIR          Save to DIR (default .)                                 
        -S              Show server response                                    
        -O FILE         Save to FILE ('-' for stdout)                           
        -U STR          Use STR for User-Agent header                           
        -Y on/off       Use proxy

It seems feature FEATURE_WGET_TIMEOUT is not enabled when busybox-1.29 was built for windows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hxietkg
Copy link
Contributor Author

hxietkg commented Feb 8, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@hxietkg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s-kawamura-w664
s-kawamura-w664 reviewed Feb 8, 2022
View reviewed changes
Copy link

@s-kawamura-w664 s-kawamura-w664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@s-kawamura-w664
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2022
@marosset
Copy link
Contributor

marosset commented Feb 8, 2022

/triage accepted
/priority important-longterm
LGTM

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2022
@marosset
Copy link
Contributor

marosset commented Feb 8, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel

@aojea
Copy link
Member

aojea commented Feb 8, 2022

/lgtm
/approve
Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, hxietkg, jayunit100

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit ab13c85 into kubernetes:master Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 8, 2022
@marosset marosset added this to Done (v1.24) in SIG-Windows Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@marosset marosset marosset left review comments

@s-kawamura-w664 s-kawamura-w664 s-kawamura-w664 left review comments

@bowei bowei Awaiting requested review from bowei

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@jayunit100 jayunit100

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.24)
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hxietkg @k8s-ci-robot @neolit123 @jayunit100 @marosset @s-kawamura-w664 @aojea