-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent enabling beta by default for new api groups #107993
Conversation
/hold I need to think through precedence of preferences.
I think that's what I want. But will it cause hairloss. |
/triage accepted |
we agreed on behavior /hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go
Outdated
Show resolved
Hide resolved
hmm..... /retest |
/hold cancel |
batchapiv1beta1.SchemeGroupVersion, | ||
discoveryv1beta1.SchemeGroupVersion, | ||
eventsv1beta1.SchemeGroupVersion, | ||
nodev1beta1.SchemeGroupVersion, // remove in 1.26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a problem, but curious why only this one has an expiry and none of the other beta versions do
/lgtm |
In support of kubernetes/enhancements#3137 .
This identifies and hardcodes the list of legacy beta resources that were enabled prior to 1.22. No new beta APIs should be enabled by default.
kubernetes/test-infra#25148 attempts to create a new job definition to test new beta APIs.
/kind feature
/sig api-machinery
/priority important-soon