Remove tolerate-unready-endpoints annotation

[tossmilestone]

Signed-off-by: He Xiaoxi tossmilestone@gmail.com

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Remove tolerate-unready-endpoints annotation in Service deprecated from 1.11, use Service.spec.publishNotReadyAddresses instead.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove `tolerate-unready-endpoints` annotation in Service deprecated from 1.11, use `Service.spec.publishNotReadyAddresses` instead.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@tossmilestone: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

it seems there are 2 operators still using it 🙃

https://grep.app/search?q=TolerateUnreadyEndpointsAnnotation&case=true

should we open an issue on their repos to warn them?

/assign @thockin

[aojea]

hmm, this annotation is not working for endpoint slices, that is default and GA since v1.21.

The deprecation started in 1.13, so I think we should remove it to not cause more confusion, we had an incident in Openshift because of this :(
/lgtm

[tossmilestone]

/retest

[tossmilestone]

@aojea the change will appear in the release note, and the users of the annotation should notice the change when upgrading k8s. So i think it's ok to remove the annotation.

[aojea]

@aojea the change will appear in the release note, and the users of the annotation should notice the change when upgrading k8s. So i think it's ok to remove the annotation.

they will notice when they use 1.21 if they use kube-proxy, because endpoint slices doesn't recognize the label and things will fail ;) ... I had an internal bug because of this

[aojea]

seems that only one of the projects is active, I've opened an issue on their repo

nats-io/nats-operator#339

[thockin]

Thanks @aojea - you did all the homework.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, tossmilestone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/endpoint/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tossmilestone]

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest