New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration: custom etcd gracefully termination #108048
Conversation
/assign @pohly @liggitt @BenTheElder |
I think that this is mostly cosmetic to reduce noise in the logs if you use |
/retest |
this is not a big deal, the job doesn't use this codepath, but implements a "more" correct behavior and I think we can have it for people that runs their tests locally |
/lgtm |
5944fbb
to
816920f
Compare
816920f
to
b4a3e7f
Compare
when running integration tests without an external etcd, the framework spawns an etcd instance executing it in its own process and killing it once the test stops. Instead of killing it directly, allow etcd to exit gracefully or kill it after 5 seconds.
b4a3e7f
to
1756fe6
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
when running integration tests without an external etcd, the framework
spawns an etcd instance executing it in its own process and killing
it once the test stops.
Instead of killing it directly, allow etcd to exit gracefully or kill
it after 5 seconds.
/kind cleanup
Before this patch:
After this patch: