Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log grabbing: obtain timestamps on extra services #108057

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Feb 11, 2022

Previously if any test jobs added additional log dumps, such as
containerd-installation for example, the logs would grabbed with sudo journalctl --output=cat. --output=cat excludes timestamps which
makes debugging difficult. Let's use short-precise output similar to
to the other log grabbing commands which includes timestamps.

As per man journalctl

--output=
           Controls the formatting of the journal entries that are
           shown. Takes one of the following options:

...

           short-precise
               is very similar, but shows classic syslog timestamps with
               full microsecond precision.

           cat
               generates a very terse output, only showing the actual
               message of each journal entry with no metadata, not even
               a timestamp. If combined with the --output-fields= option
               will output the listed fields for each log record,
               instead of the message.

Signed-off-by: David Porter david@porter.me

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Previously if any test jobs added additional log dumps, such as
`containerd-installation` for example, the logs would grabbed with `sudo
journalctl --output=cat`. `--output=cat` excludes timestamps which
makes debugging difficult. Let's use `short-precise` output similar to
to the other log grabbing commands which includes timestamps.

Signed-off-by: David Porter <david@porter.me>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 11, 2022
@bobbypage
Copy link
Member Author

bobbypage commented Feb 11, 2022

/assign @dims
/cc @SergeyKanzhelev

This should make debugging a bit simpler, timestamps can be very useful :). For example the containerd-installation.log don't have timestamps currently due to being grabbed with --output=cat.

I'm not sure why we didn't include timestamps here in the first place, but I don't see any downside with including them.

@bobbypage
Copy link
Member Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label Feb 11, 2022
@bobbypage
Copy link
Member Author

/retest

@dims
Copy link
Member

dims commented Feb 11, 2022

/approve
/lgtm
/skip
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@dims
Copy link
Member

dims commented Feb 11, 2022

/retest
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 11, 2022
@mborsz
Copy link
Member

mborsz commented Feb 16, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, dims, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@mborsz
Copy link
Member

mborsz commented Feb 16, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2ccdd45 into kubernetes:master Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants