-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log grabbing: obtain timestamps on extra services #108057
Conversation
Previously if any test jobs added additional log dumps, such as `containerd-installation` for example, the logs would grabbed with `sudo journalctl --output=cat`. `--output=cat` excludes timestamps which makes debugging difficult. Let's use `short-precise` output similar to to the other log grabbing commands which includes timestamps. Signed-off-by: David Porter <david@porter.me>
/assign @dims This should make debugging a bit simpler, timestamps can be very useful :). For example the I'm not sure why we didn't include timestamps here in the first place, but I don't see any downside with including them. |
/sig testing |
/retest |
/approve |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobbypage, dims, mborsz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Previously if any test jobs added additional log dumps, such as
containerd-installation
for example, the logs would grabbed withsudo journalctl --output=cat
.--output=cat
excludes timestamps whichmakes debugging difficult. Let's use
short-precise
output similar toto the other log grabbing commands which includes timestamps.
As per
man journalctl
Signed-off-by: David Porter david@porter.me
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: