e2e: Fix ResourceConsumer unstable request interval

[pbetkier]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Setting a new consumption target in autoscaling.ResourceConsumer (a call e.g. to rc.ConsumeCPU(...)) caused the internal sleep duration between consumption requests to reset. The next consumption would then get delayed, starting after a gap of 0-30s.

This bug is not visible in the current e2e tests, because they only loosely validate the scaling behavior – waiting a long time for the number of replicas to eventually reach a given target. Even if the gap in the resource consumption causes a bad recommendation, then that only makes the test to run a bit longer. However, it impacts the tests I'm about to add for #102369, as they will validate exactly how the target is reached.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Piotr Betkier (4c9d3d5)

[k8s-ci-robot]

@pbetkier: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @pbetkier!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pbetkier. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pbetkier]

/sig autoscaling

[kerthcet]

/ok-to-test

[pohly]

Someone from SIG autoscaling needs to look at this, I don't know this code.

[pbetkier]

For better explanation: sample of logs before the fix (should send requests every 30s, irrelevant logs omitted):

Feb 11 13:04:50.113: INFO: RC test-deployment: sending request to consume 250 millicores
Feb 11 13:05:20.403: INFO: RC test-deployment: sending request to consume 250 millicores
Feb 11 13:05:40.339: INFO: RC test-deployment: setting consumption to 700 millicores in total
Feb 11 13:06:10.339: INFO: RC test-deployment: sending request to consume 700 millicores
Feb 11 13:06:40.498: INFO: RC test-deployment: sending request to consume 700 millicores

and after the fix:

Feb 11 11:07:18.274: INFO: RC test-deployment: sending request to consume 250 millicores
Feb 11 11:07:48.426: INFO: RC test-deployment: sending request to consume 250 millicores
Feb 11 11:07:58.652: INFO: RC test-deployment: setting consumption to 700 millicores in total
Feb 11 11:08:18.576: INFO: RC test-deployment: sending request to consume 700 millicores
Feb 11 11:08:48.730: INFO: RC test-deployment: sending request to consume 700 millicores

[pbetkier]

cc @josephburnett

[pbetkier]

cc @krzysied @jbartosik

[jbartosik]

/lgmt
/approve

[jbartosik]

/lgtm

[pbetkier]

@pohly got lgtm from autoscaling member, could you approve?

[pohly]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, pbetkier, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/framework/OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest