Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: etcd: use sub-tests #108173

Merged
merged 5 commits into from
Feb 17, 2022
Merged

storage: etcd: use sub-tests #108173

merged 5 commits into from
Feb 17, 2022

Conversation

stevekuznetsov
Copy link
Contributor

Sub-tests are much friendlier to anyone breaking these tests than the old-school methods.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/kind cleanup
/sig api-machinery
/cc @stts @liggitt

NONE

@k8s-ci-robot
Copy link
Contributor

@stevekuznetsov: GitHub didn't allow me to request PR reviews from the following users: stts.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Sub-tests are much friendlier to anyone breaking these tests than the old-school methods.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/kind cleanup
/sig api-machinery
/cc @stts @liggitt

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Feb 16, 2022
@stevekuznetsov
storage: etcd: TestGetToList: use sub-tests
f1ded3b 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
storage: etcd: TestGuaranteedUpdate: use sub-tests
b6a6625 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
storage: etcd: TestUnconditionalDelete: use sub-tests
dbb0069 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
storage: etcd: TestConditionalDelete: use sub-tests
7729691 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
Copy link
Contributor Author

@liggitt PTAL - was able to shorten them all, removed redundant prefixes and changed stories to explicit things (e.g. "minimum resource version set to current resource version" became "resourceVersion=current")

@liggitt
Copy link
Member

liggitt commented Feb 16, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 16, 2022
@stevekuznetsov
storage: etcd: shorten sub-test names
4e166ff 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
@stevekuznetsov
Copy link
Contributor Author

@liggitt sorry, looks like my editor was being goofy with gofmt-on-save, needs another LGTM please

@liggitt
Copy link
Member

liggitt commented Feb 17, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit b6549ec into kubernetes:master Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 17, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevekuznetsov @k8s-ci-robot @liggitt @fedebongio