storage: transformers: pass a context.Context #108174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
stevekuznetsov
force-pushed
the
skuznets/transformer-context
branch
from
9a24739
to
3f06d71
Compare
k8s-ci-robot
added
size/L
stevekuznetsov
commented
Feb 16, 2022
| @@ -199,13 +200,13 @@ func TestEncryptionProviderConfigCorrect(t *testing.T) { | |||
| } | |||
|
|
|||
| for _, testCase := range transformers { | |||
| transformedData, err := testCase.Transformer.TransformToStorage(originalText, context) | |||
There was a problem hiding this comment.
The diff is a little larger than it has to be since I renamed these so as to not collide with the package name.
stevekuznetsov
commented
Feb 16, 2022
| @@ -2250,7 +2250,7 @@ func TestConsistentList(t *testing.T) { | |||
| transformer.store = store | |||
|
|
|||
| for i := 0; i < 5; i++ { | |||
| if err := transformer.createObject(); err != nil { | |||
| if err := transformer.createObject(context.TODO()); err != nil { | |||
There was a problem hiding this comment.
My follow-up will be to change these, at which point only the top-level contexts will need any change.
k8s-ci-robot
added
area/apiserver
sig/auth
stevekuznetsov
force-pushed
the
skuznets/transformer-context
branch
from
3f06d71
to
bcd5ab3
Compare
k8s-ci-robot
added
area/test
sig/testing
liggitt
reviewed
Feb 17, 2022
liggitt
reviewed
Feb 17, 2022
stevekuznetsov
force-pushed
the
skuznets/transformer-context
branch
from
bcd5ab3
to
b1a13f6
Compare
liggitt
reviewed
Feb 17, 2022
staging/src/k8s.io/apiserver/pkg/server/options/encryptionconfig/config_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/aes/aes_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/aes/aes_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/envelope_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/envelope_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/secretbox/secretbox_test.go
Outdated
Show resolved
Hide resolved
When an envelope transformer calls out to KMS (for instance), it will be very helpful to pass a `context.Context` to allow for cancellation. This patch does that, while passing the previously-expected additional data via a context value. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/transformer-context
branch
from
b1a13f6
to
27312fe
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an envelope transformer calls out to KMS (for instance), it will be
very helpful to pass a
context.Contextto allow for cancellation. Thispatch does that, while passing the previously-expected additional data
via a context value.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/kind cleanup
/sig api-machinery
/cc @deads2k @liggitt @enj