Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is no need for gci-docker-version and gci-ensure-gke-docker - t… #108195

Merged
merged 1 commit into from Jun 1, 2022
Merged

there is no need for gci-docker-version and gci-ensure-gke-docker - t… #108195

merged 1 commit into from Jun 1, 2022

Conversation

SergeyKanzhelev
Copy link
Member

…hose are not used by COS or any of scripts

/kind cleanup
/sig node
/assign @bsdnet

The only reference to one of these is being removed here: #108192

@bsdnet to re-confirm those are not real COS metadata keys.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@SergeyKanzhelev
there is no need for gci-docker-version and gci-ensure-gke-docker - t…
0e5dffc 
…hose are not used by COS or any of scripts

Change-Id: I317c95d8fd2f51598cfa3e710380552d8fc07d2d
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. release-note-none Denotes a PR that doesn't merit a release note. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/gcp Issues or PRs related to gcp provider labels Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Feb 17, 2022
@rkolchmeyer
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@rkolchmeyer: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev
Copy link
Member Author

/test pull-kubernetes-unit

@SergeyKanzhelev
Copy link
Member Author

/unassign @bsdnet

since @rkolchmeyer lgtm-ed

@SergeyKanzhelev
Copy link
Member Author

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2022
@SergeyKanzhelev
Copy link
Member Author

/assign @cheftako

@pacoxu pacoxu moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 1, 2022
@mmiranda96
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 21, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 22, 2022
@bsdnet
Copy link
Contributor

bsdnet commented Mar 24, 2022

I do not think COS uses those metadata attributes

@bsdnet
Copy link
Contributor

bsdnet commented Mar 24, 2022

/lgtm

@ehashman ehashman moved this from Done to Needs Approver in SIG Node PR Triage Mar 30, 2022
@cheftako
Copy link
Member

cheftako commented Jun 1, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 875d48b into kubernetes:master Jun 1, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 1, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the unusedMetadataKeys branch January 23, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@marseel marseel Awaiting requested review from marseel

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@cheftako cheftako

@bsdnet bsdnet

@mmiranda96 mmiranda96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SergeyKanzhelev @rkolchmeyer @k8s-ci-robot @mmiranda96 @bsdnet @cheftako @mrunalp