pkg/proxy/userspace/roundrobin: Make lb.services nil check standardized

[carlosdmz]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As suggested in here, some portions of the code contains the map checking for nil values in lb.services map, and others don't have. Even though we're never assigning nil values to this map, we should standardize the portions that does not have this check in roundrobin module.

Example:

state, exists := lb.services[svcPort]
return exists && state != nil && len(state.endpoints) > 0

Should be like this:

state, exists := lb.services[svcPort]
if !exists || state == nil {
      return false
}
return len(state.endpoints) > 0

Which issue(s) this PR fixes:

Fixes #108257

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Carlos Damazio (fd6a053)

[k8s-ci-robot]

Welcome @carlosdamazio!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @carlosdamazio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dcbw]

/ok-to-test

[dcbw]

/lgtm
/approve

[dcbw]

/triage accepted

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlosdamazio, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/proxy/userspace/OWNERS [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carlosdmz]

/retest

[carlosdmz]

/retest

[carlosdmz]

/retest

[carlosdmz]

@dcbw could you give lgtm again? Needed to fix the formatting.

[dcbw]

/lgtm