Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename SchedulerCache to Cache in Scheduler #108269

Merged
merged 2 commits into from
Feb 24, 2022
Merged

refactor: rename SchedulerCache to Cache in Scheduler #108269

merged 2 commits into from
Feb 24, 2022

Conversation

kerthcet
Copy link
Member

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refactoring for idiomatic Go code

Which issue(s) this PR fixes:

Fixes #108240

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 22, 2022
@kerthcet
Copy link
Member Author

/sig scheduling
/hold until #107135 is merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. area/test and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 22, 2022
@ahg-g
Copy link
Member

ahg-g commented Feb 22, 2022

can you also change schedulerCache to cacheImpl?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2022
@kerthcet kerthcet force-pushed the refactor/rename-schedulercache-to-cache branch from 1a40fde to edbe104 Compare February 23, 2022 03:46
@kerthcet
Copy link
Member Author

/retest

denkensk
denkensk reviewed Feb 23, 2022
View reviewed changes
pkg/scheduler/internal/cache/cache.go Outdated
return &framework.ImageStateSummary{
Size: state.size,
NumNodes: len(state.nodes),
}
}

func newSchedulerCache(ttl, period time.Duration, stop <-chan struct{}) *schedulerCache {
return &schedulerCache{
func newSchedulerCache(ttl, period time.Duration, stop <-chan struct{}) *cacheImpl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newSchedulerCache --> newCacheImpl or just newCache?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I renamed this to newCacheImpl , but then I realized it's just one implementation, so I changed back. newCache seems good to me.

pkg/scheduler/eventhandlers_test.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/scheduler/eventhandlers_test.go Outdated Show resolved Hide resolved
@kerthcet
refactor: rename schedulerCache to cacheImpl in internal cache
09623be 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet
refactor: rename SchedulerCache to Cache in Scheduler
eafbaad 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the refactor/rename-schedulercache-to-cache branch from f773676 to eafbaad Compare February 24, 2022 02:10
@kerthcet
Copy link
Member Author

As this pr promoted faster, I'd like to merge this first. cc @ruquanzhao , you may have to rebase your pr then.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2022
@kerthcet
Copy link
Member Author

/retest

@denkensk
Copy link
Member

Squash ?

@kerthcet
Copy link
Member Author

Squash ?

I'd like to keep two commits here as they are independent. Make sense?

@alculquicondor
Copy link
Member

All good

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2022
@denkensk
Copy link
Member

Approve is also needed. 😄

@alculquicondor
Copy link
Member

I already approved. You are missing one from test owners

@aojea
Copy link
Member

aojea commented Feb 24, 2022

I already approved. You are missing one from test owners

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, aojea, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@Huang-Wei
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit d3ece70 into kubernetes:master Feb 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 24, 2022
@kerthcet kerthcet deleted the refactor/rename-schedulercache-to-cache branch February 25, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk denkensk left review comments

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

rename SchedulerCache to Cache in Scheduler
7 participants
@kerthcet @k8s-ci-robot @ahg-g @denkensk @alculquicondor @aojea @Huang-Wei