New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write replaceCoreV1NamespacedPodTemplate test - +1 endpoint coverage #108286

Merged

k8s-ci-robot merged 1 commit into kubernetes:master from ii:replace-pod-template

Mar 1, 2022

Contributor

riaankleinhans commented Feb 23, 2022 •

edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoint:

replaceCoreV1NamespacedPodTemplate

Which issue(s) this PR fixes:
Fixes #108285
Testgrid Link:
Testgid

Special notes for your reviewer:
Adds +1 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance

k8s-ci-robot added release-note-none kind/cleanup size/M sig/testing sig/architecture area/conformance needs-triage needs-priority cncf-cla: yes labels

k8s-ci-robot requested review from pacoxu and sjenning

February 23, 2022 00:41

k8s-ci-robot added the area/test label

Contributor Author

riaankleinhans commented Feb 23, 2022

/triage accepted

k8s-ci-robot added sig/node triage/accepted and removed needs-triage labels

riaankleinhans mentioned this pull request

Write replaceCoreV1NamespacedPodTemplate test - +1 endpoint coverage #108285

Closed

6 tasks

riaankleinhans added this to In Progress /Active Issues in conformance-definition

Member

heyste commented Feb 23, 2022

/test pull-kubernetes-unit
unrelated flake

=== Failed
=== FAIL: pkg/kubelet/nodeshutdown  (0.00s)
=== CONT  
    testing.go:1152: race detected during execution of test
FAIL
FAIL	k8s.io/kubernetes/pkg/kubelet/nodeshutdown	2.708s

Member

heyste commented Feb 23, 2022

/test pull-kubernetes-node-e2e-containerd
unrelated flake [It] should report resource usage through the stats api

W0223 01:05:57.907] Looking for address 'bootstrap-e2e-master-ip'
W0223 01:05:58.667] ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:
W0223 01:05:58.668]  - The resource 'projects/k8s-infra-e2e-boskos-010/regions/us-west1/addresses/bootstrap-e2e-master-ip' was not found

Member

heyste commented Feb 23, 2022

/test pull-kubernetes-e2e-kind-ipv6
unrelated flake Pod Container lifecycle should not create extra sandbox if all containers are done

/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/node/pods.go:484
Feb 23 01:11:58.548: Unexpected error:     
<*errors.errorString \| 0xc000210250>: {
         s: "timed out waiting for the condition",
     }
     timed out waiting for the condition
occurred
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/node/pods.go:528

SergeyKanzhelev added this to Triage in SIG Node CI/Test Board

SergeyKanzhelev added this to Triage in SIG Node PR Triage

SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board

Member

SergeyKanzhelev commented Feb 23, 2022

/priority backlog

k8s-ci-robot added priority/backlog and removed needs-priority labels

Member

SergeyKanzhelev commented Feb 23, 2022

/cc @endocrimes

k8s-ci-robot requested a review from endocrimes

February 23, 2022 18:17

endocrimes reviewed

View reviewed changes

Member

endocrimes left a comment

Took a quick first pass - Seems like an ok happy-path test, we might want to add a failure case test too? (that some field cannot be updated for example)

test/e2e/common/node/podtemplates.go Outdated

    
              	})

              	ginkgo.It("should replace a pod template", func() {

Member

endocrimes Feb 23, 2022

Suggested change

nit: rm extra line here

Member

heyste Feb 24, 2022

Fixed

test/e2e/common/node/podtemplates.go Outdated

    
              		err = retry.RetryOnConflict(retry.DefaultRetry, func() error {

              			ptResource, err = ptClient.Get(context.TODO(), ptName, metav1.GetOptions{})

              			framework.ExpectNoError(err, "Unable to pod template %s", ptName)

Member

endocrimes Feb 23, 2022

Suggested change

      
            			framework.ExpectNoError(err, "Unable to pod template %s", ptName)
          
            			framework.ExpectNoError(err, "Unable to get pod template %s", ptName)

Member

heyste Feb 24, 2022

Fixed

test/e2e/common/node/podtemplates.go Outdated

    
              		ptResource, err := ptClient.Create(context.TODO(), &v1.PodTemplate{

              			ObjectMeta: metav1.ObjectMeta{

              				Name:   ptName,

              				Labels: map[string]string{"podtemplate-set": "true"},

Member

endocrimes Feb 23, 2022

Copy/paste from the previous test? - should probably be removed here because we don't use it in the test.

Member

heyste Feb 24, 2022

Fixed. Removed Line 176 reference for Labels

pacoxu reviewed

View reviewed changes

test/e2e/common/node/podtemplates.go Outdated

Comment on lines 187 to 197

    
              		ptResource.Annotations = map[string]string{

              			"updated": "true",

              		}

              		updatedPT, err := ptClient.Update(context.TODO(), ptResource, metav1.UpdateOptions{})

              		err = retry.RetryOnConflict(retry.DefaultRetry, func() error {

              			ptResource, err = ptClient.Get(context.TODO(), ptName, metav1.GetOptions{})

              			framework.ExpectNoError(err, "Unable to get pod template %s", ptName)

              			updatedPT, err = ptClient.Update(context.TODO(), ptResource, metav1.UpdateOptions{})

              			return err

              		})

Member

pacoxu Feb 24, 2022

Suggested change

      
            		ptResource.Annotations = map[string]string{
          
            			"updated": "true",
          
            		}
          
            		updatedPT, err := ptClient.Update(context.TODO(), ptResource, metav1.UpdateOptions{})
          
            		err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
          
            			ptResource, err = ptClient.Get(context.TODO(), ptName, metav1.GetOptions{})
          
            			framework.ExpectNoError(err, "Unable to get pod template %s", ptName)
          
            			updatedPT, err = ptClient.Update(context.TODO(), ptResource, metav1.UpdateOptions{})
          
            			return err
          
            		})
          
            		var updatedPT *v1.PodTemplate
          
            		err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
          
            			ptResource, err = ptClient.Get(context.TODO(), ptName, metav1.GetOptions{})
          
            			framework.ExpectNoError(err, "Unable to get pod template %s", ptName)
          
            			ptResource.Annotations = map[string]string{
          
            				"updated": "true",
          
            			}
          
            			updatedPT, err = ptClient.Update(context.TODO(), ptResource, metav1.UpdateOptions{})
          
            			return err
          
            		})

Member

heyste Feb 25, 2022

Fixed

pacoxu reviewed

View reviewed changes

test/e2e/common/node/podtemplates.go

    
              		err = retry.RetryOnConflict(retry.DefaultRetry, func() error {

              			ptResource, err = ptClient.Get(context.TODO(), ptName, metav1.GetOptions{})

              			framework.ExpectNoError(err, "Unable to get pod template %s", ptName)

Member

pacoxu Feb 24, 2022

ptResource.Annotations will not contain updated=true annotation after the Get.


          Create e2e replace pod template test

522b9b3

The test validates the following endpoint
- replaceCoreV1NamespacedPodTemplate

heyste force-pushed the replace-pod-template branch from 2576286 to 522b9b3 Compare

February 25, 2022 02:29

Member

heyste commented Feb 25, 2022

/test pull-kubernetes-unit
unrelated flake?

 === FAIL: vendor/k8s.io/client-go/metadata/metadatainformer TestMetadataSharedInformerFactory/scenario_1:_test_if_adding_an_object_triggers_AddFunc (3.00s)
...
     --- FAIL: TestMetadataSharedInformerFactory/scenario_1:_test_if_adding_an_object_triggers_AddFunc (3.00s)
=== FAIL: vendor/k8s.io/client-go/metadata/metadatainformer TestMetadataSharedInformerFactory (3.21s)

Member

pacoxu commented Feb 25, 2022

unrelated flake?

Yes, http://storage.googleapis.com/k8s-triage/index.html?test=TestMetadataSharedInformerFactory#d59fc0e85a18c3eb481b

Member

heyste commented Feb 25, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel
multiple unrelated flakes

 s: "timed out waiting for the condition",

Member

pacoxu commented Feb 25, 2022

/lgtm
/assign @SergeyKanzhelev

k8s-ci-robot assigned SergeyKanzhelev

pacoxu moved this from Triage to Needs Approver in SIG Node PR Triage

k8s-ci-robot assigned pacoxu

k8s-ci-robot added the lgtm label

pacoxu moved this from PRs - Needs Reviewer to PRs - Needs Approver in SIG Node CI/Test Board

Member

heyste commented Feb 25, 2022

/test pull-kubernetes-conformance-kind-ipv6-parallel
multiple unrelated flakes

Unexpected error:
    <*errors.errorString | 0xc000210250>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred

Member

heyste commented Feb 25, 2022

/test pull-kubernetes-integration
unrelated flake

JUnit
133/133 Tests Passed!

Checking the end of build-log.txt

/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 2h0m0s timeout","severity":"error","time":"2022-02-25T04:31:35Z"}

endocrimes approved these changes

View reviewed changes

Member

endocrimes left a comment

/lgtm

k8s-ci-robot assigned endocrimes

Member

dims commented Feb 28, 2022

/approve
/hold

k8s-ci-robot added do-not-merge/hold approved labels

SergeyKanzhelev approved these changes

View reviewed changes

Member

SergeyKanzhelev left a comment

/unhold

k8s-ci-robot removed the do-not-merge/hold label

Contributor

k8s-ci-robot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, endocrimes, Riaankl, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e/common/OWNERS~~ [SergeyKanzhelev,dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrunalp moved this from Needs Approver to Done in SIG Node PR Triage

k8s-ci-robot merged commit 1cc8edb into kubernetes:master

conformance-definition automation moved this from In Progress /Active Issues to Done

SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done

k8s-ci-robot added this to the v1.24 milestone

riaankleinhans moved this from Done to Promotion PRs Needing Two Weeks (flake free) in conformance-definition

riaankleinhans moved this from Promotion PRs Needing Two Weeks (flake free) to Done in conformance-definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

heyste heyste left review comments

pacoxu pacoxu left review comments

endocrimes endocrimes approved these changes

SergeyKanzhelev SergeyKanzhelev approved these changes

sjenning Awaiting requested review from sjenning

Labels

approved area/conformance area/test cncf-cla: yes kind/cleanup lgtm priority/backlog release-note-none sig/architecture sig/node sig/testing size/M triage/accepted