Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect CNI installation in local-up-cluster.sh #108295

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Detect CNI installation in local-up-cluster.sh #108295

merged 1 commit into from
Feb 25, 2022

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Feb 23, 2022 •
edited

Signed-off-by: Aditi Sharma adi.sky17@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Detect CNI installation in hack/local-up-cluster.sh, if not it installs CNI plugin

Which issue(s) this PR fixes:

Fixes #108168

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2022
@k8s-ci-robot
Copy link
Contributor

@adisky: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2022
@adisky adisky force-pushed the install-cni-if-not-installed branch from 04566ba to 67349ba Compare February 23, 2022 11:07
sftim
sftim reviewed Feb 23, 2022
View reviewed changes
hack/local-up-cluster.sh Outdated Show resolved Hide resolved
sftim
sftim reviewed Feb 23, 2022
View reviewed changes
hack/local-up-cluster.sh Outdated Show resolved Hide resolved
@adisky adisky changed the title Detect CNI installtion in local-up-cluster.sh Detect CNI installation in local-up-cluster.sh Feb 23, 2022
@adisky adisky force-pushed the install-cni-if-not-installed branch from 67349ba to abf8f77 Compare February 23, 2022 11:53
@adisky
Copy link
Contributor Author

adisky commented Feb 23, 2022

/cc @ehashman @dims

dims
dims reviewed Feb 23, 2022
View reviewed changes
hack/local-up-cluster.sh Outdated Show resolved Hide resolved
@adisky
Detect CNI installtion in local-up-cluster.sh
2e7b783 
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
@adisky adisky force-pushed the install-cni-if-not-installed branch from abf8f77 to 2e7b783 Compare February 23, 2022 16:06
@dims
Copy link
Member

dims commented Feb 25, 2022

/approve
/lgtm
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 356ec6f into kubernetes:master Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 25, 2022
@adisky adisky mentioned this pull request Feb 25, 2022
Merged
@adisky adisky deleted the install-cni-if-not-installed branch April 4, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@sftim sftim sftim left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@spiffxp spiffxp Awaiting requested review from spiffxp

@ehashman ehashman Awaiting requested review from ehashman

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

local-up-cluster.sh: doesn't install CNI plugins if needed
4 participants
@adisky @k8s-ci-robot @dims @sftim