Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for default service account instead of its token #108313

Merged
merged 1 commit into from
Feb 24, 2022
Merged

wait for default service account instead of its token #108313

merged 1 commit into from
Feb 24, 2022

Conversation

zshihang
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

addon manager only needs to wait for the creation of default service account not its token.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2022
@k8s-ci-robot
Copy link
Contributor

@zshihang: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 23, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 23, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 24, 2022
@zshihang
Copy link
Contributor Author

/assign @MrHohn
what's the process to push an image? i don't have permission to do so.

/cc @liggitt

@MrHohn
Copy link
Member

MrHohn commented Feb 24, 2022

what's the process to push an image? i don't have permission to do so.

That process is currently manual - I will do the push once this is in.

MrHohn
MrHohn approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I will approve once the version bumps are removed.

cluster/gce/manifests/kube-addon-manager.yaml Outdated Show resolved Hide resolved
test/kubemark/resources/manifests/kube-addon-manager.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Feb 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2022
@MrHohn
Copy link
Member

MrHohn commented Feb 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 673fa1d into kubernetes:master Feb 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 24, 2022
@spencer-p spencer-p mentioned this pull request Feb 24, 2022
Closed
@MrHohn MrHohn mentioned this pull request Feb 24, 2022
Merged
liggitt
liggitt reviewed Feb 24, 2022
View reviewed changes
cluster/addons/addon-manager/Makefile
@@ -15,7 +15,7 @@
IMAGE=gcr.io/k8s-staging-addon-manager/kube-addon-manager
ARCH?=amd64
TEMP_DIR:=$(shell mktemp -d)
VERSION=v9.1.5
VERSION=v9.1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you open the PR to bump to this image version, also update the changelog to note the fix

hswong3i added a commit to alvistack/ansible-role-kube_addon_manager that referenced this pull request Mar 4, 2022
@hswong3i
https://github.com/kubernetes/kubernetes/pull/108313
8281c63
@pacoxu pacoxu mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@MrHohn MrHohn MrHohn approved these changes

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zshihang @k8s-ci-robot @MrHohn @liggitt