-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: clean up static/nonstatic build output #108376
Makefile: clean up static/nonstatic build output #108376
Conversation
This allows common flags to be passed in (upcoming commits).
before: ``` $ make generated_files +++ [0226 13:42:17] Building go targets for linux/amd64: hack/make-rules/helpers/go2make > non-static build: k8s.io/kubernetes/hack/make-rules/helpers/go2make ``` after: ``` $ make generated_files +++ [0226 14:30:08] Building go targets for linux/amd64 k8s.io/kubernetes/hack/make-rules/helpers/go2make (non-static) ```
@thockin: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Slightly nicer output when building
before:
after:
or:
The "Building go targets..." lines are once per invocation of build.sh. I don't love it but it's better than before? TGhe alternative would be to emit one "Building go target" for each target, but we don't call
go build
once per binary, so the timestamps are kind of a lie./kind cleanup