Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the last zz_generated.openapi.go file #108381

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Add the last zz_generated.openapi.go file #108381

merged 1 commit into from
Mar 1, 2022
+55,637 −12

Conversation

thockin
Copy link
Member

@thockin thockin commented Feb 28, 2022

We had 4 of 5 checked in.

/kind cleanup

Fixes #107625

NONE

@thockin thockin added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Feb 28, 2022
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 28, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@liggitt
Copy link
Member

liggitt commented Feb 28, 2022

/lgtm
/approve

Do the verify scripts making sure generated committed content is correct pick this up automatically and make sure it's up to date?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2022
@thockin
Copy link
Member Author

thockin commented Feb 28, 2022

hold while I triple check

@dims
Copy link
Member

dims commented Feb 28, 2022

/approve
/lgtm

thanks for triple-checking! :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member Author

thockin commented Feb 28, 2022 •
edited

/remove-hold

!!! Generated code is out of date:
 M pkg/generated/openapi/zz_generated.openapi.go

Please run make generated_files.

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@thockin
Copy link
Member Author

thockin commented Feb 28, 2022

rebased

@thockin
Copy link
Member Author

thockin commented Feb 28, 2022

/retest

@dims
Copy link
Member

dims commented Mar 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2022
@dims
Copy link
Member

dims commented Mar 1, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 50e07c9 into kubernetes:master Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 1, 2022
@liggitt liggitt mentioned this pull request Mar 2, 2022
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 3, 2022
@thockin thockin deleted the add-generated-openapi branch July 6, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

4 of 5 zz_generated.openapi.go files are checked in - why?
5 participants
@thockin @liggitt @dims @k8s-ci-robot @fedebongio