Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start building etcd v3.6.0-alpha.0 image for scalability tests #108389

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

serathius
Copy link
Contributor

/kind feature

NONE

/sig scalability

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. release-note-none Denotes a PR that doesn't merit a release note. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2022
@serathius
Copy link
Contributor Author

/sig release

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 28, 2022
@serathius
Copy link
Contributor Author

/assign @dims

@pacoxu
Copy link
Member

pacoxu commented Mar 1, 2022

During reading the changelog of etcd v3.6, there is a breaking change and has it any influences to Kubernetes upgradetion?

  • Breaking Changes etcd will no longer start on data dir created by newer versions (for example etcd v3.6 will not run on v3.7+ data dir). To downgrade data dir please check out etcdutl migrate command.

@serathius
Copy link
Contributor Author

serathius commented Mar 1, 2022

During reading the changelog of etcd v3.6, there is a breaking change and has it any influences to Kubernetes upgradetion?

  • Breaking Changes etcd will no longer start on data dir created by newer versions (for example etcd v3.6 will not run on v3.7+ data dir). To downgrade data dir please check out etcdutl migrate command.

This change is in data compatibility policy for downgrades. Etcd never really supported downgrades as it recommenced to restore backup from before upgrade, however it prevented users from doing so. Fact that data was backward compatible was never guaranteed nor validated.

With introduction of downgrade support to etcd we are trying to provide a downgrade guarantees, however this first comes with restrictions about removing unsafe operations. With v3.6 etcd will no longer allow administrators to just downgrade the binary and run on the same data directory. On the other side etcd will provide an tooling and documentation about how a proper etcd downgrade process should be executed.

As this change is in downgrade behavior to v3.6, there is no immediate impact of this PR to K8s as it only changes ability of downgrading from v3.7 to v3.6. As for future actions that K8s should do for v3.7, it will require updating K8s https://github.com/kubernetes/kubernetes/blob/master/cluster/images/etcd/migrate-if-needed.sh script to utilize official etcd tooling like etcdutl migrate.

@pacoxu
Copy link
Member

pacoxu commented Mar 1, 2022

Thanks for the clarification.

@dims
Copy link
Member

dims commented Mar 1, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit bed430d into kubernetes:master Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 1, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants