-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log where we pull images from in an e2e test #108417
Log where we pull images from in an e2e test #108417
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest /assign @BenTheElder @ameukam |
@dims Looking for guidance about this. I may have missed this. |
@ameukam see https://cs.k8s.io/?q=KUBE_TEST_REPO_LIST&i=nope&files=&excludeFiles=&repos= example yaml https://raw.githubusercontent.com/kubernetes-sigs/windows-testing/master/images/image-repo-list the code for defaults is here kubernetes/test/utils/image/manifest.go Lines 88 to 99 in c67a19d
|
/kind cleanup |
/lgtm |
/kind cleanup
In this PR, we just run
docker images
orctr images list
to dump all the image infoAt some point we will be making changes to the repository from where we pick up images. We already have a way to inject the location of images for the conformance tests etc, So this will make it easy to eyeball if we are using the correct repositories for each image.
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: