csi: add validation of secretRef format for CSI PV update functions #108418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
@humblec: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
|
/sig storage |
k8s-ci-robot
added
sig/storage
|
/test pull-kubernetes-e2e-kind-ipv6 |
|
/test pull-kubernetes-e2e-kind |
|
Cc @jsafrane |
humblec
force-pushed
the
add-expansion-secret-validation
branch
2 times, most recently
from
6b090ef
to
08597c0
Compare
k8s-ci-robot
added
size/L
humblec
force-pushed
the
add-expansion-secret-validation
branch
3 times, most recently
from
61c8427
to
c986c84
Compare
k8s-ci-robot
added
area/dependency
humblec
force-pushed
the
add-expansion-secret-validation
branch
from
c986c84
to
9ee6ed4
Compare
humblec
force-pushed
the
add-expansion-secret-validation
branch
4 times, most recently
from
c22d118
to
9e4d408
Compare
liggitt
reviewed
Mar 8, 2022
humblec
force-pushed
the
add-expansion-secret-validation
branch
3 times, most recently
from
8211d58
to
0fe781a
Compare
humblec
force-pushed
the
add-expansion-secret-validation
branch
from
0fe781a
to
6f46f06
Compare
|
/test pull-kubenetes-integration |
|
@humblec: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-integration |
|
/test pull-kubernetes-e2e-kind-ipv6 |
liggitt
reviewed
Mar 9, 2022
at present the spec.csi.secretRef name has to be DNS1035 label format and it should fail if we use DNSSubdomain secretRef in the secretReference field of CSI spec. The newly added test cases validate this behaviour in validation tests for controllerPublish, nodePublish and nodeStage secretRef formats. Additionally csiExpansionEnabled struct field also removed from the validation function. Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec
force-pushed
the
add-expansion-secret-validation
branch
from
6f46f06
to
f247378
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks a lot @liggitt for your quick review 👍 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the spec.csi.secretRef name has to be DNS1035 label
format and it should fail if we use DNSSubdomain secretRef in
the secretReference field of CSI spec. The newly added test cases
validate this behaviour in validation tests for controllerPublish,
nodePublish and nodeStage secretRef formats.
This PR also does below:
csiExpansionEnabledstruct field has been removed from the validation test functionSigned-off-by: Humble Chirammal hchiramm@redhat.com
/kind cleanup