-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark PodOverhead to GA in v1.24; remove in v1.26 #108441
Conversation
/assign @kubernetes/api-reviewers @kubernetes/sig-node-api-reviews |
/triage accepted |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
and in |
Thank you for submitting this @pacoxu. I was working on similar one with the Conformance test added. But those can be split and I can send conformance test separately. Added a small nits and please update fields descriptions in various types.go files |
/priority important-soon |
PR for conformance test for PodOverhead: #108714 |
/test pull-kubernetes-integration |
/approve lgtm, squash in "address comments" commit before merge |
lgtm |
Thanks for reviewing. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, liggitt, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-unit |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
/sig node
some documentation and comments that mention
PodOverhead
should be removed when the feature is removed in v1.26.Which issue(s) this PR fixes:
xref kubernetes/enhancements#688
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: