-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specifying pause image in containerd config.toml #108456
Enable specifying pause image in containerd config.toml #108456
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @palnabarun @ameukam |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
/test pull-kubernetes-e2e-gce-registry-sandbox |
/lgtm |
/retest |
/kind cleanup
We lost (or forgot to add) the ability to specify a pause container in the config.toml file. Earlier when we used dockershim only the pause image was threaded through a kubelet command-line param as well, now we have to edit the config file for each CRI.
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: