Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: run test cases in eachs own subtest #108477

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 3, 2022

/kind cleanup

NONE

Use subtests to run each test case, so the subtest is cleaned inmediatly, otherwise the tests are piling up closeFn functions that run once all of them finish

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 3, 2022
@aojea
Copy link
Member Author

aojea commented Mar 3, 2022

/assign @sttts @liggitt

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2022
@aojea aojea changed the title integration: run tests in eachs own process integration: run test cases in eachs own subtest Mar 3, 2022
@aojea
Copy link
Member Author

aojea commented Mar 3, 2022

Kubernetes e2e suite: [sig-storage] Downward API volume should update labels on modification [NodeConformance] [Conformance] expand_less

/retest

before

junit_20220228-120137.stdout:{"Time":"2022-02-28T12:10:44.736944161Z","Action":"output","Package":"k8s.io/kubernetes/test/integration/controlplane","Test":"TestStatus","Output":"--- PASS: TestStatus (13.60s)\n"}

after

junit_20220303-074418.stdout:{"Time":"2022-03-03T07:52:53.551987242Z","Action":"output","Package":"k8s.io/kubernetes/test/integration/controlplane","Test":"TestStatus","Output":"--- PASS: TestStatus (13.41s)\n"}
junit_20220303-074418.stdout:{"Time":"2022-03-03T07:52:53.552006285Z","Action":"output","Package":"k8s.io/kubernetes/test/integration/controlplane","Test":"TestStatus/404","Output":"    --- PASS: TestStatus/404 (4.50s)\n"}
junit_20220303-074418.stdout:{"Time":"2022-03-03T07:52:53.552025085Z","Action":"output","Package":"k8s.io/kubernetes/test/integration/controlplane","Test":"TestStatus/403","Output":"    --- PASS: TestStatus/403 (4.45s)\n"}
junit_20220303-074418.stdout:{"Time":"2022-03-03T07:52:53.552039285Z","Action":"output","Package":"k8s.io/kubernetes/test/integration/controlplane","Test":"TestStatus/401","Output":"    --- PASS: TestStatus/401 (4.46s)\n"}

@aojea
Copy link
Member Author

aojea commented Mar 3, 2022

/retest

@liggitt
Copy link
Member

liggitt commented Mar 3, 2022

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@aojea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-conformance-kind-ipv6-parallel b0600c6 link false /test pull-kubernetes-conformance-kind-ipv6-parallel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 3a52f8b into kubernetes:master Mar 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants