-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: delete unused function NewNodeInfoLister #108479
Conversation
@Abirdcfly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Abirdcfly. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig scheduling |
/assign @damemi |
/ok-to-test |
squash to one commit? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Abirdcfly, ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the function (and probably the type too) is unused. Please remove it instead.
/remove-kind bug |
I have thought about deleting this function directly, but it is a public function and there may be other projects that are calling this function, will there be any compatibility issues if I delete this function directly? |
I didn't find any usages in cluster-autoscaler, descheduler or scheduler-plugins. kubernetes/kubernetes is not supposed to be a library, so we don't care about keeping exported functions that we (kubernetes projects is general) are not using. |
I agree and the code has been updated.😊 |
Can you remove the NodeInfoLister type as well? |
Change-Id: I1fb0d92d952b5cbf61633936a0c05f639f4f9600
I'm afraid not, there is some code that uses this type. |
Sg, thanks /lgtm |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: