Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS file for stable metrics #108503

Merged
merged 1 commit into from May 4, 2022
Merged

Update OWNERS file for stable metrics #108503

merged 1 commit into from May 4, 2022

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Mar 3, 2022

What type of PR is this?

/kind cleanup
/sig instrumentation
/priority important-longterm

What this PR does / why we need it:

Ensures SIG Instrumentation approves stable metrics changes.

Adds a new label to stable metrics PRs to pull in a helpful bot comment with docs.

/hold
until kubernetes/test-infra#25499 merges with the label
until kubernetes/community#6518 merges with docs

Which issue(s) this PR fixes:

Fixes #108497

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2022
@dashpole
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2022
@dashpole
Copy link
Contributor

/assign

@ehashman
Copy link
Member Author

ehashman commented Apr 7, 2022

/hold cancel
/retest-required

Prerequisite PRs have been merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@ehashman
Copy link
Member Author

ehashman commented Apr 8, 2022

/retest-required

logicalhan
logicalhan approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dashpole
Copy link
Contributor

dashpole commented Apr 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@serathius
Copy link
Contributor

Have we got an ack from root approvers?

@logicalhan
Copy link
Member

Have we got an ack from root approvers?

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 8, 2022 •
edited

/approve

(consistent with packages with special approval processes, like API approval or conformance enumeration)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, liggitt, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9ebaeaa into kubernetes:master May 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@coffeepac coffeepac Awaiting requested review from coffeepac

Assignees

@logicalhan logicalhan

@liggitt liggitt

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Flag stable metric changes for additional approval
6 participants
@ehashman @dashpole @serathius @logicalhan @liggitt @k8s-ci-robot