Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kubectl describe ingress shows default-backend:80 when no default… #108506

Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix kubectl describe ingress shows default-backend:80 when no default… #108506

merged 1 commit into from
Mar 18, 2022

Conversation

jlsong01
Copy link
Contributor

@jlsong01 jlsong01 commented Mar 4, 2022 •
edited

What type of PR is this?

/kind bug
/sig cli

What this PR does / why we need it:

kubectl describe ingress shows default-backend:80 when no default backend is present

Which issue(s) this PR fixes:

Fixes #107720
kubernetes/kubectl#1172

cc @soltysh

Special notes for your reviewer:

Does this PR introduce a user-facing change?

print <default> as the value in case kubectl describe ingress shows default-backend:80 when no default backend is present

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 4, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2022
@jlsong01 jlsong01 force-pushed the fix_kubectl_ingress_default_backend branch from a4eab42 to 7a42698 Compare March 4, 2022 02:03
@jlsong01 jlsong01 force-pushed the fix_kubectl_ingress_default_backend branch from 7a42698 to 344297a Compare March 4, 2022 03:52
@jlsong01
Copy link
Contributor Author

jlsong01 commented Mar 4, 2022

/retest

@jlsong01 jlsong01 force-pushed the fix_kubectl_ingress_default_backend branch from 344297a to 75c139d Compare March 5, 2022 14:54
@jlsong01 jlsong01 requested a review from soltysh March 5, 2022 15:57
@jlsong01
Copy link
Contributor Author

@soltysh The change request is done. Could you please take a look again?

soltysh
soltysh approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlsong01, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit afbe293 into kubernetes:master Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 18, 2022
@sftim sftim mentioned this pull request Jul 7, 2022
Closed
@SvenKirschbaum SvenKirschbaum mentioned this pull request Oct 30, 2022
Closed
@laphets laphets mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianghao208 lianghao208 lianghao208 left review comments

@wangyysde wangyysde wangyysde left review comments

@soltysh soltysh soltysh approved these changes

@dougsland dougsland Awaiting requested review from dougsland

@eddiezane eddiezane Awaiting requested review from eddiezane

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

kubectl describe ingress shows default-backend:80 when no default backend is present.
5 participants
@jlsong01 @k8s-ci-robot @soltysh @lianghao208 @wangyysde