Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typo #108535

Merged
merged 1 commit into from
Mar 6, 2022
Merged

fix some typo #108535

merged 1 commit into from
Mar 6, 2022

Conversation

Abirdcfly
Copy link
Member

@Abirdcfly Abirdcfly commented Mar 5, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 5, 2022
@k8s-ci-robot
Copy link
Contributor

@Abirdcfly: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Abirdcfly. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubeadm area/test sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2022
@Abirdcfly
Copy link
Member Author

/assign @thockin @BenTheElder @dchen1107

@pacoxu
Copy link
Member

pacoxu commented Mar 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2022
@MadhavJivrajani
Copy link
Contributor

A spell check is done as part of the CI: https://github.com/kubernetes/kubernetes/blob/master/hack/verify-spelling.sh
Is the goal here to replace this?

@Abirdcfly
Copy link
Member Author

A spell check is done as part of the CI: https://github.com/kubernetes/kubernetes/blob/master/hack/verify-spelling.sh Is the goal here to replace this?

Sorry for the rough first pr, Let me first figure out why misspell didn't check out retrive -> retrive and deleteing ->deleting, and then re-open this pr. 😂

@Abirdcfly Abirdcfly closed this Mar 5, 2022
@Abirdcfly
Copy link
Member Author

A spell check is done as part of the CI: https://github.com/kubernetes/kubernetes/blob/master/hack/verify-spelling.sh Is the goal here to replace this?

Sorry for the rough first pr, Let me first figure out why misspell didn't check out retrive -> retrive and deleteing ->deleting, and then re-open this pr. 😂

I figured it out.

The golangci-lint use a fork of original misspell which add more pr.

The original misspell's latest merge is 9 Mar 2018. A backporting pr has been committed to the original misspell repository for this change, but it remains in the open state.

And After my test, directly changing github.com/client9/misspell to github.com/golangci/misspell does not work.

Because the original misspell is hard-coded with a word list to distinguish miswriting, and the misspell project directly references the package, for this problem golangci's approach is close to rewriting the main function of misspll directly (not only for this reason, of course)

@Abirdcfly Abirdcfly reopened this Mar 5, 2022
@Abirdcfly Abirdcfly marked this pull request as draft March 5, 2022 09:36
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2022
Change-Id: I211f572555e964581214a5d726ac552676c9833a
@Abirdcfly Abirdcfly changed the title Add misspell to .golangci.yaml fix some typo Mar 5, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2022
@Abirdcfly Abirdcfly marked this pull request as ready for review March 5, 2022 15:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from aojea and RA489 March 5, 2022 15:29
@Abirdcfly
Copy link
Member Author

/retest

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abirdcfly, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3775ac6 into kubernetes:master Mar 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants