-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some typo #108535
fix some typo #108535
Conversation
@Abirdcfly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Abirdcfly. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @thockin @BenTheElder @dchen1107 |
/ok-to-test |
A spell check is done as part of the CI: https://github.com/kubernetes/kubernetes/blob/master/hack/verify-spelling.sh |
Sorry for the rough first pr, Let me first figure out why misspell didn't check out retrive -> retrive and deleteing ->deleting, and then re-open this pr. 😂 |
I figured it out. The golangci-lint use a fork of original misspell which add more pr. The original misspell's latest merge is 9 Mar 2018. A backporting pr has been committed to the original misspell repository for this change, but it remains in the open state. And After my test, directly changing Because the original misspell is hard-coded with a word list to distinguish miswriting, and the misspell project directly references the package, for this problem golangci's approach is close to rewriting the main function of misspll directly (not only for this reason, of course) |
Change-Id: I211f572555e964581214a5d726ac552676c9833a
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Abirdcfly, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: