-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generic_scheduler.go and generic_scheduler_test.go #108557
Remove generic_scheduler.go and generic_scheduler_test.go #108557
Conversation
Signed-off-by: Ruquan Zhao <ruquan.zhao@arm.com>
@ruquanzhao: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ruquanzhao. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
One nit, otherwise looks good to me as it's just a code migration. |
@@ -50,6 +53,7 @@ import ( | |||
"k8s.io/kubernetes/pkg/scheduler/metrics" | |||
"k8s.io/kubernetes/pkg/scheduler/profile" | |||
"k8s.io/kubernetes/pkg/scheduler/util" | |||
utiltrace "k8s.io/utils/trace" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it seems trace
is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
But I notice that the "k8s.io/utils/trace"
is imported as utiltrace
for most situations. So I prefer to keep it.
/approve |
/release-note-none |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, ruquanzhao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ruquan Zhao ruquan.zhao@arm.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #101135
Special notes for your reviewer:
Follow work of #107135
Remove
generic_scheduler.go
andgeneric_schedule_test.go
sincegeneric_scheduler
is removedDoes this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: