Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate nginx to k8s.gcr.io image #108581

Merged
merged 2 commits into from
Mar 11, 2022
Merged

migrate nginx to k8s.gcr.io image #108581

merged 2 commits into from
Mar 11, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 8, 2022 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

test/e2e/common/node/podtemplates.go change may be not needed. (Update it by the way. It has no side effect, I think)

Which issue(s) this PR fixes:

part of #108562

Special notes for your reviewer:

Only replaced nginx images in this PR.
Some other image has no alternative image: #108562 (comment)

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Mar 8, 2022

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims March 8, 2022 09:03
dims
dims reviewed Mar 8, 2022
View reviewed changes
test/e2e/testing-manifests/statefulset/nginx/statefulset.yaml
@@ -15,7 +15,7 @@ spec:
spec:
containers:
- name: nginx
image: nginx:1.15-alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know where we load this yaml and make the modification there? using imageutils.GetE2EImage in the code in addition to modifying yaml here? ( the GetE2EImage allows folks to inject alternate repositories )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test/e2e/framework/manifest/manifest.go, StatefulSetFromManifest will use it. I changed that.

dims
dims reviewed Mar 8, 2022
View reviewed changes
test/e2e/testing-manifests/pod Outdated Show resolved Hide resolved
@leilajal
Copy link
Contributor

leilajal commented Mar 8, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Mar 9, 2022

/test pull-kubernetes-unit

@dims
Copy link
Member

dims commented Mar 10, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liangyuanpeng, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit c5f7ceb into kubernetes:master Mar 11, 2022
SIG Node CI/Test Board automation moved this from Triage to Done Mar 11, 2022
SIG Node PR Triage automation moved this from Triage to Done Mar 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 11, 2022
@pacoxu pacoxu mentioned this pull request Apr 7, 2022
Closed
@pacoxu pacoxu deleted the image-docker-hub-fix branch May 10, 2022 06:28
@csuzhangxc csuzhangxc mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pacoxu @leilajal @dims @k8s-ci-robot @liangyuanpeng