Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the legacy Nginx testcases #108598

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

chendave
Copy link
Member

@chendave chendave commented Mar 9, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Those testcases does't work anymore after nginx-ingress controller
has been upgraded to v1.

Signed-off-by: Dave Chen <dave.chen@arm.com>
`error` is the keywork in golang

Signed-off-by: Dave Chen <dave.chen@arm.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

@chendave: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 9, 2022
@chendave
Copy link
Member Author

chendave commented Mar 9, 2022

/release-note-none
/sig testing
/sig network

this is alternative to #108326

@aojea I haven't embed the ingress manifest in this pr. Some of the testcase like [sig-network] Loadbalancing: L7 GCE [Slow] [Feature:NEG] [Flaky] should be able to switch between IG and NEG modes still need the file in that directory, but consider those testcases can only run with "gce", "gke", maybe we can just let it be.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 9, 2022
@chendave
Copy link
Member Author

chendave commented Mar 9, 2022

/retest

@danwinship
Copy link
Contributor

You should probably split off the errorerr fix into a separate PR since neither of the two commits here depends on the other, and they require different approvers because they're in different parts of the tree.

I can approve the network parts if someone else confirms that we actually do want to do this... it sounds like we're undecided about this vs #108326 right now

@aojea
Copy link
Member

aojea commented Mar 9, 2022

You should probably split off the errorerr fix into a separate PR since neither of the two commits here depends on the other, and they require different approvers because they're in different parts of the tree.

I can approve the network parts if someone else confirms that we actually do want to do this... it sounds like we're undecided about this vs #108326 right now

discussion is here, it's ok to remove them
#108324 (comment)

nginx ingress has its own CI and nobody is maintaining these tests, when ingress deprecated beta I had to disable them because the project didn't supported the v1 API 🤷

@aojea
Copy link
Member

aojea commented Mar 9, 2022

👀

/test pull-kubernetes-e2e-gci-gce-ipvs

@aojea
Copy link
Member

aojea commented Mar 9, 2022

ahh, the ingress job passed

pull-kubernetes-e2e-gci-gce-ingress — Job succeeded.                     BaseSHA:f10cd679eb5f5805cb6bdf1fabc19d918affac80

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, chendave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4763d75 into kubernetes:master Mar 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 9, 2022
@chendave chendave deleted the remove_testcases branch March 10, 2022 01:49
@jefferycline1
Copy link

Renovate scheduling automatic. 5 pm everyday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants