-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the legacy Nginx testcases #108598
Conversation
Those testcases does't work anymore after nginx-ingress controller has been upgraded to v1. Signed-off-by: Dave Chen <dave.chen@arm.com>
`error` is the keywork in golang Signed-off-by: Dave Chen <dave.chen@arm.com>
@chendave: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-none this is alternative to #108326 @aojea I haven't embed the ingress manifest in this pr. Some of the testcase like |
/retest |
You should probably split off the I can approve the network parts if someone else confirms that we actually do want to do this... it sounds like we're undecided about this vs #108326 right now |
discussion is here, it's ok to remove them nginx ingress has its own CI and nobody is maintaining these tests, when ingress deprecated beta I had to disable them because the project didn't supported the v1 API 🤷 |
👀 /test pull-kubernetes-e2e-gci-gce-ipvs |
ahh, the ingress job passed pull-kubernetes-e2e-gci-gce-ingress — Job succeeded. BaseSHA:f10cd679eb5f5805cb6bdf1fabc19d918affac80 /lgtm Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, chendave The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Renovate scheduling automatic. 5 pm everyday. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: